Fix #27523: throw informative errors in setup:db:generate-patch

[korostii]

Description (*)

In most cases, if there is indeed a write permission issue, the error does show the complete path to directory which cannot be created:

However, if the requested module does not exist, the console command will compile an invalid(incomplete) target path and will show a rather cryptic error message:

Fixed Issues (if relevant)

1. Fixes CLI Patch Generator: Lack of information what path cannot be created #27523: CLI Patch Generator: Lack of information what path cannot be created

Manual testing scenarios (*)

1. Run php bin/magento setup:db-declaration:generate-patch Vendor_Module SomePatch, while there isn't any registered modules with name matching Vendor_Module
2. You should see an informative error message like Cannot find a registered module with name "Vendor_Module"

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @korostii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

Hi @korostii. Thank you for fixing the issues mentioned earlier. There was a comment from me regarding suffixing mock properties with Mock suffix. The same applies to the variables. This suffix improves code readability by letting know straight away what object we are working on mock or a real instance.

Just a recommendation for the future 😉

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7280 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Run: php bin/magento setup:db-declaration:generate-patch Vendor_Module SomePatch

Before:

After:

[korostii]

Please fix the failing tests after upgrade to PHP 7.4

Fixed.

[engcom-Kilo]

@magento run all tests

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-7280 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Run: php bin/magento setup:db-declaration:generate-patch Vendor_Module SomePatch

Before:

After:

[m2-assistant]

Hi @korostii, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.