Fix text overlap in sales PDFs #2779
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D is not being printed
|
Hello @CNanninga, can you please update the code and cover it by Travis tests? |
|
Hi @CNanninga, |
NadiyaS
added
the
Issue: Ready for Work
vkorotun
added
Component: Sales
bugfix
and removed
Issue: Ready for Work
vkorotun
added
Issue: Ready for Work
|
Closing PR as not updated more than 14 days. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 2, 2018
[Plankton]: Merge 2.2.5 Release into 2.2-develop Branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Magento\Sales\Model\Order\Pdf\AbstractPdf::insertOrder, the current vertical coordinate ($top) is advanced 30 units for the order ID, which leaves space above it for the document ID (shipment, invoice, etc) to be printed above it. For the next text to be printed, order date, the vertical coordinate is advanced another 15 units to put it under order ID. However, printing of order ID can be disabled in Store Configuration, and if this setting is off, order date is printed on its own, with only the 15 units change in the vertical coordinate. This results in the order date text overlapping the eventual placement of the document ID.
To fix this, the vertical coordinate is being advanced appropriately if the order ID is not being printed, before printing the order date.