-
Notifications
You must be signed in to change notification settings - Fork 9.4k
fixed validation for bundle checkbox options #27854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed validation for bundle checkbox options #27854
Conversation
Hi @ProkopovVitaliy. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @ProkopovVitaliy. Thank you for the fix, it's very useful. Would you cover your change with MFTF test, please? Thank you! |
@rogyar covered with MFTF test ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ProkopovVitaliy. Great job, thank you. Please, take a look at some required minor adjustments.
...de/Magento/Bundle/Test/Mftf/ActionGroup/AssertStorefrontBundleValidationCountActionGroup.xml
Outdated
Show resolved
Hide resolved
...de/Magento/Bundle/Test/Mftf/ActionGroup/AssertStorefrontBundleValidationCountActionGroup.xml
Outdated
Show resolved
Hide resolved
app/code/Magento/Bundle/Test/Mftf/Test/StorefrontBundleCheckBoxOptionValidationTest.xml
Outdated
Show resolved
Hide resolved
Also, please, take a look at the failing static tests |
…BundleValidationCountActionGroup.xml Co-authored-by: Yaroslav Rogoza <[email protected]>
…BundleValidationCountActionGroup.xml Co-authored-by: Yaroslav Rogoza <[email protected]>
@magento run all tests |
@magento run Functional Tests EE |
@magento run all tests |
@magento run Unit Tests |
Hi @rogyar, thank you for the review. |
✔️ QA Passed Manual testing scenario:
Before: ✖️ Show many messages After: ✔️ JS checked and showed one error message for Option Checked also and on Blank theme ✔️ |
@magento run all tests |
Hi @ProkopovVitaliy, thank you for your contribution! |
@ProkopovVitaliy |
Description (*)
JS should validate and show one error message for Option
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)