Skip to content

fixed validation for bundle checkbox options #27854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 13, 2020
Merged

fixed validation for bundle checkbox options #27854

merged 21 commits into from
Jun 13, 2020

Conversation

ProkopovVitaliy
Copy link
Contributor

@ProkopovVitaliy ProkopovVitaliy commented Apr 14, 2020

Description (*)

JS should validate and show one error message for Option

Related Pull Requests

Fixed Issues (if relevant)

  1. JS validate: show many messsages for Bundle product with checkbox option  #27489: Issue title JS validate: show many messsages for Bundle product with checkbox option

Manual testing scenarios (*)

  1. Create bundle product
  2. Add option. Option Name: anything; Input Type: Checkbox; Required
  3. Add product to Option
  4. Add to cart on store front.
  5. From validate if no option selected.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 14, 2020

Hi @ProkopovVitaliy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rogyar rogyar self-assigned this Apr 22, 2020
@rogyar
Copy link
Contributor

rogyar commented Apr 22, 2020

Hi @ProkopovVitaliy. Thank you for the fix, it's very useful. Would you cover your change with MFTF test, please?

Thank you!

@rogyar rogyar added Award: bug fix Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Apr 22, 2020
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Apr 30, 2020
@ProkopovVitaliy
Copy link
Contributor Author

@rogyar covered with MFTF test )

Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ProkopovVitaliy. Great job, thank you. Please, take a look at some required minor adjustments.

@rogyar
Copy link
Contributor

rogyar commented May 11, 2020

Also, please, take a look at the failing static tests

@rogyar rogyar added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels May 11, 2020
ProkopovVitaliy and others added 2 commits May 12, 2020 15:05
…BundleValidationCountActionGroup.xml

Co-authored-by: Yaroslav Rogoza <[email protected]>
…BundleValidationCountActionGroup.xml

Co-authored-by: Yaroslav Rogoza <[email protected]>
@ProkopovVitaliy
Copy link
Contributor Author

@magento run all tests

@rogyar
Copy link
Contributor

rogyar commented Jun 3, 2020

@magento run Functional Tests EE

@rogyar
Copy link
Contributor

rogyar commented Jun 8, 2020

@magento run all tests

@rogyar
Copy link
Contributor

rogyar commented Jun 9, 2020

@magento run Unit Tests

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7655 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Create a bundle product
  2. Add option in Bundle Items section:
  • Option Name: Test1;
  • Input Type: Checkbox;
  • Required
    Screenshot from 2020-06-12 09-42-41
  1. Add products to Option;
  2. Go to Storefront;
  3. Open the bundle product page;
  4. Click on Add to Cart button (no option selected)

Before: ✖️ Show many messages

Screenshot from 2020-06-12 09-44-31

After: ✔️ JS checked and showed one error message for Option

Screenshot from 2020-06-12 09-54-30

Checked also and on Blank theme ✔️

Screenshot from 2020-06-12 10-20-53

@engcom-Charlie engcom-Charlie self-assigned this Jun 12, 2020
@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 12, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 12, 2020
@magento-engcom-team magento-engcom-team merged commit 6ef62c8 into magento:2.4-develop Jun 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2020

Hi @ProkopovVitaliy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@jmcharadva
Copy link

@ProkopovVitaliy
Still there is one issue in this solution. Its working when you are using single group of checkbox section but it's not working while you have multiple sections. Please check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: MFTF test coverage Component: Bundle Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

JS validate: show many messsages for Bundle product with checkbox option
7 participants