Skip to content

MFTF: Share wishlist with not valid email address #28330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DmitryTsymbal
Copy link
Contributor

@DmitryTsymbal DmitryTsymbal commented May 22, 2020

This PR contains MFTF test for Customer's WishList sharing with not valid email addresses.
PR contains refactoring of existed test for wishlist sharing (StorefrontShareWishlistEntityTest)
Deprecated StorefrontCustomerShareWishlistActionGroup due to hardcoded WishList Data Using.
Announced new StorefrontShareCustomerWishlistActionGroup due to best practices.

Steps to reproduce:
1 - Login as a Customer
2 - Add product into WishList
3 - Fill in share info emails with invalid emails
4 - Click the "Share WishList" button
5 - Perform Assertions

Resolved issues:

  1. resolves [Issue] MFTF: Share wishlist with not valid email address #28377: MFTF: Share wishlist with not valid email address

@m2-assistant
Copy link

m2-assistant bot commented May 22, 2020

Hi @DmitryTsymbal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Wishlist Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 22, 2020
@dmytro-ch dmytro-ch self-assigned this May 22, 2020
@dmytro-ch dmytro-ch self-requested a review May 22, 2020 09:12
@dmytro-ch
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7580 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage labels May 22, 2020
@engcom-Alfa engcom-Alfa self-assigned this May 22, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie
Copy link
Contributor

Failed test not related to changes from this PR.

@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label May 25, 2020
@slavvka
Copy link
Member

slavvka commented May 26, 2020

@magento create issue

@slavvka slavvka added the Priority: P3 May be fixed according to the position in the backlog. label May 27, 2020
@slavvka slavvka added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label May 27, 2020
@slavvka slavvka added this to the 2.4.1 milestone May 27, 2020
@sdzhepa sdzhepa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 3, 2020
@magento-engcom-team magento-engcom-team merged commit 9250e69 into magento:2.4-develop Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @DmitryTsymbal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Wishlist Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Issue] MFTF: Share wishlist with not valid email address
7 participants