Fix Downloadable product after refund #28413

ProkopovVitaliy · 2020-05-28T17:48:48Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Downloadable product is available in My Download Products tab after it has been partially refunded #28388. Downloadable product is available in My Download Products tab after it has been partially refunded

Manual testing scenarios (*)

Create order with a download product and a product, requiring shipping, (e.g. simple product) is created.
The downloadable product is available in My Downloadable Products tab.
Open this order page in Admin.
Perform a partial refund for the downloadable product (the other product is not refunded).
Go to My Downloadable Products tab.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-05-28T17:48:50Z

Hi @ProkopovVitaliy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

ProkopovVitaliy · 2020-05-28T17:50:00Z

@magento run all tests

…fix-28388

ProkopovVitaliy · 2020-05-29T06:02:17Z

@magento run all tests

VladimirZaets

Hi @ProkopovVitaliy. Thanks for collaboration. Can you please fix failed tests? Also, can you please cover this functionality by functional or integration tests?

engcom-Kilo · 2020-06-09T14:19:34Z

@magento run all tests

ProkopovVitaliy · 2020-06-09T18:28:50Z

@magento run Functional Tests EE

engcom-Kilo · 2020-06-10T07:47:04Z

Working with MFTF test.

engcom-Kilo · 2020-06-10T13:07:34Z

@magento run all tests

ProkopovVitaliy · 2020-06-10T16:19:24Z

@magento run Unit Tests

ProkopovVitaliy · 2020-06-10T16:20:51Z

@magento run Functional Tests B2B

engcom-Kilo · 2020-08-14T13:56:55Z

@magento run Functional Tests CE

engcom-Kilo · 2020-08-14T13:57:14Z

@magento run Functional Tests B2B

engcom-Kilo · 2020-08-15T08:49:02Z

@magento run all tests

sidolov · 2020-08-21T19:41:10Z

app/code/Magento/Downloadable/Test/Unit/Observer/SetLinkStatusObserverTest.php

@@ -189,7 +189,7 @@ public function testSetLinkStatusPending($orderState, array $orderStateMapping)
                ]
            );

-        $this->itemsFactory->expects($this->once())
+        $this->itemsFactory->expects($this->any())


It's better to use atLeastOnce instead.

sidolov · 2020-08-21T19:41:35Z

app/code/Magento/Downloadable/Test/Unit/Observer/SetLinkStatusObserverTest.php

@@ -390,7 +524,7 @@ private function createLinkItemCollection(array $expectedOrderItemIds, array $it
            ->disableOriginalConstructor()
            ->setMethods(['addFieldToFilter'])
            ->getMock();
-        $linkItemCollection->expects($this->once())
+        $linkItemCollection->expects($this->any())


It's better to use atLeastOnce instead.

magento-engcom-team · 2020-08-21T19:47:43Z

Hi @sidolov, thank you for the review.
ENGCOM-7679 has been created to process this Pull Request

engcom-Alfa · 2020-08-31T08:19:17Z

✔️ QA Passed

Preconditions:

Has a Simple product;
Has a Downloadable product;
Has a customer in Storefront;

Manual testing scenario:

Create order with a download product and a product, requiring shipping, (e.g. simple product) is created;
Create a full invoice for the order;
Perform a partial refund (credit memo) for the downloadable product (the other product is not refunded).

Go to Storefront-> My Account -> My Downloadable Products again

Before: ✖️ After a refund, the Downloadable product still can be downloaded.

After: ✔️ The Downloadable product cannot be downloaded.

Also tested with different stores, combinations with different types of products

m2-assistant · 2020-09-02T17:08:29Z

Hi @ProkopovVitaliy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ProkopovVitaliy added 2 commits May 28, 2020 16:29

fixed refund issue for downloadable items

a6f460d

added unit test

9a83830

ghost added the Progress: pending review label May 28, 2020

magento-engcom-team added Component: Downloadable Release Line: 2.4 labels May 28, 2020

Merge branch '2.4-develop' into fix-28388

96c9d54

ProkopovVitaliy added 2 commits May 29, 2020 08:54

added short description

59cf9f7

Merge branch 'fix-28388' of github.com:ProkopovVitaliy/magento2 into …

c6c3231

…fix-28388

ghost added Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Jun 1, 2020

VladimirZaets requested changes Jun 3, 2020

View reviewed changes

ghost assigned VladimirZaets Jun 3, 2020

ghost added Progress: needs update and removed Progress: pending review labels Jun 3, 2020

engcom-Kilo self-assigned this Jun 9, 2020

Merge branch '2.4-develop' into fix-28388

eafdb17

engcom-Kilo and others added 2 commits June 10, 2020 10:49

Merge branch '2.4-develop' into fix-28388

92fd06b

MFTF test.

1f7eace

engcom-Kilo added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 10, 2020

VladimirZaets approved these changes Jun 12, 2020

View reviewed changes

ghost removed the Progress: needs update label Jun 12, 2020

engcom-Kilo and others added 2 commits August 14, 2020 16:42

Merge branch '2.4-develop' into fix-28388

97df424

MFTF update.

2d58988

Merge branch '2.4-develop' into fix-28388

87d8984

ghost added Progress: pending review and removed Progress: needs update labels Aug 19, 2020

sidolov approved these changes Aug 21, 2020

View reviewed changes

ghost assigned sidolov Aug 21, 2020

ghost added Progress: ready for testing and removed Progress: pending review labels Aug 21, 2020

magento-engcom-team added Component: Catalog Component: Customer Component: Wishlist labels Aug 21, 2020

engcom-Kilo removed their assignment Aug 25, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 31, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Aug 31, 2020

engcom-Charlie self-assigned this Aug 31, 2020

ghost added Progress: accept and removed Progress: extended testing labels Aug 31, 2020

magento-engcom-team mentioned this pull request Sep 2, 2020

Downloadable product is available in My Download Products tab after it has been partially refunded #28388

Closed

5 tasks

magento-engcom-team pushed a commit that referenced this pull request Sep 2, 2020

ENGCOM-7679: Fix Downloadable product after refund #28413

b93a17d

magento-engcom-team merged commit ed6c29f into magento:2.4-develop Sep 2, 2020

sdzhepa mentioned this pull request Jun 22, 2021

[TEST ISSUES] #32961

Closed

5 tasks

Fix Downloadable product after refund #28413

Fix Downloadable product after refund #28413

Uh oh!

Conversation

ProkopovVitaliy commented May 28, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented May 28, 2020

Uh oh!

ProkopovVitaliy commented May 28, 2020

Uh oh!

ProkopovVitaliy commented May 29, 2020

Uh oh!

VladimirZaets left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Kilo commented Jun 9, 2020

Uh oh!

ProkopovVitaliy commented Jun 9, 2020

Uh oh!

engcom-Kilo commented Jun 10, 2020

Uh oh!

engcom-Kilo commented Jun 10, 2020

Uh oh!

ProkopovVitaliy commented Jun 10, 2020

Uh oh!

ProkopovVitaliy commented Jun 10, 2020

Uh oh!

engcom-Kilo commented Aug 14, 2020

Uh oh!

engcom-Kilo commented Aug 14, 2020

Uh oh!

engcom-Kilo commented Aug 15, 2020

Uh oh!

sidolov Aug 21, 2020

Choose a reason for hiding this comment

Uh oh!

sidolov Aug 21, 2020

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Aug 21, 2020

Uh oh!

engcom-Alfa commented Aug 31, 2020

Uh oh!

m2-assistant bot commented Sep 2, 2020

Uh oh!

Uh oh!