Fix failing / warnings in unit tests by lbajsarowicz · Pull Request #28599 · magento/magento2

lbajsarowicz · 2020-06-07T15:10:17Z

Description (*)

2.4.1-develop branch contains failing Unit tests - I've fixed that in scope of PR
Also - On 5th of June new version (9.2 of PHPUnit was released) I've upgraded it.

OK, but incomplete, skipped, or risky tests!
Tests: 15243, Assertions: 45840, Skipped: 87, Incomplete: 40.

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-06-07T15:10:19Z

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

lbajsarowicz · 2020-06-07T15:12:19Z

@magento run all tests

rogyar

@lbajsarowicz good job!

magento-engcom-team · 2020-06-08T13:14:33Z

Hi @rogyar, thank you for the review.
ENGCOM-7632 has been created to process this Pull Request

engcom-Alfa

Hi @lbajsarowicz . Could you resolve merge conflicts?
Thanks!

Pull Request state was updated. Re-review required.

…-patch-information # Conflicts: # composer.lock

lbajsarowicz · 2020-06-11T09:57:46Z

I see that Magento Functional Testing Framework RC4 is coming, so probably we will need to resolve composer.lock a few more times.

composer update --with-dependencies allure-framework/allure-phpunit dealerdirect/phpcodesniffer-composer-installer friendsofphp/php-cs-fixer lusitanian/oauth magento/magento-coding-standard pdepend/pdepend phpcompatibility/php-compatibility phpmd/phpmd phpstan/phpstan phpunit/phpunit sebastian/phpcpd squizlabs/php_codesniffer

lbajsarowicz · 2020-06-11T10:05:08Z

@magento run all tests

…-patch-information # Conflicts: # composer.lock

lbajsarowicz · 2020-07-27T10:18:22Z

I am unable to resolve conflicts anymore.

I mean there is something introduced with regular dependencies which causes set of conflicts during composer update or composer require I'll revert the changes to composer.json and composer.lock leaving only fixes to tests.

lbajsarowicz · 2020-07-27T10:23:12Z

@magento run all tests

lbajsarowicz · 2020-08-02T15:26:42Z

@magento run all tests

Fun fact: My PR is hanging for 2 months already, but most of the same changes performed last week (https://github.com/magento/magento2/pull/29244/files) were already merged.

What is more fun: The Magento 2.4 was released with the Unit Test bugs, even though the fix was already there 👏

magento-engcom-team · 2020-08-12T09:14:33Z

Hi @rogyar, thank you for the review.
ENGCOM-7632 has been created to process this Pull Request

engcom-Alfa · 2020-08-12T09:50:59Z

QA not applicable

engcom-Echo · 2020-08-12T09:59:29Z

@magento run all tests

m2-assistant · 2020-08-14T07:22:56Z

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Upgrade PHPUnit and fix failing / warnings in tests

415291b

ghost added the Progress: pending review label Jun 7, 2020

magento-engcom-team added Component: CatalogImportExport Component: Developer Component: ProductVideo Component: Quote Component: Sales Release Line: 2.4 Partner: Mediotype partners-contribution Pull Request is created by Magento Partner labels Jun 7, 2020

rogyar self-assigned this Jun 8, 2020

rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 8, 2020

rogyar previously approved these changes Jun 8, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: pending review labels Jun 8, 2020

engcom-Alfa self-assigned this Jun 11, 2020

engcom-Alfa requested changes Jun 11, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: ready for testing labels Jun 11, 2020

Merge remote-tracking branch 'origin/2.4-develop' into feature/failed…

fd7cecb

…-patch-information # Conflicts: # composer.lock

Perform upgrade of -dev dependencies again

246dd8c

lbajsarowicz changed the title ~~Upgrade PHPUnit and fix failing / warnings in tests~~ Upgrade PHPUnit 9.2 and fix failing / warnings in tests Jun 12, 2020

lbajsarowicz added 2 commits June 22, 2020 10:12

Merge remote-tracking branch 'origin/2.4-develop' into feature/failed…

8911d03

…-patch-information # Conflicts: # composer.lock

Upgrade to PHPUnit 9.2.5

7a108aa

Merge remote-tracking branch 'origin/2.4-develop' into feature/failed…

17ae2d9

…-patch-information # Conflicts: # composer.lock

lbajsarowicz changed the title ~~Upgrade PHPUnit 9.2 and fix failing / warnings in tests~~ Fix failing / warnings in unit tests Jul 27, 2020

Revert composer.json to the state of 2.4-develop

f8f53e4

Merge branch '2.4-develop' into feature/failed-patch-information

d1d6610

engcom-Echo self-assigned this Aug 10, 2020

engcom-Echo requested a review from rogyar August 10, 2020 09:06

rogyar added the Award: category of expertise label Aug 12, 2020

rogyar approved these changes Aug 12, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 12, 2020

magento-engcom-team added Partner: Blue Acorn iCi and removed Component: Sales labels Aug 12, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 12, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Aug 12, 2020

engcom-Echo added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 12, 2020

Merge branch '2.4-develop' into feature/failed-patch-information

8671601

ghost added Progress: accept and removed Progress: extended testing labels Aug 13, 2020

magento-engcom-team pushed a commit that referenced this pull request Aug 14, 2020

ENGCOM-7632: Upgrade PHPUnit and fix failing / warnings in tests #28599

ed0a36b

magento-engcom-team merged commit 9d5aa22 into magento:2.4-develop Aug 14, 2020

Uh oh!

Conversation

lbajsarowicz commented Jun 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant Bot commented Jun 7, 2020

Uh oh!

lbajsarowicz commented Jun 7, 2020

Uh oh!

rogyar left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Jun 8, 2020

Uh oh!

engcom-Alfa left a comment

Choose a reason for hiding this comment

Uh oh!

lbajsarowicz commented Jun 11, 2020

Uh oh!

lbajsarowicz commented Jun 11, 2020

Uh oh!

lbajsarowicz commented Jul 27, 2020

Uh oh!

lbajsarowicz commented Jul 27, 2020

Uh oh!

lbajsarowicz commented Aug 2, 2020

Uh oh!

magento-engcom-team commented Aug 12, 2020

Uh oh!

engcom-Alfa commented Aug 12, 2020

Uh oh!

engcom-Echo commented Aug 12, 2020

Uh oh!

m2-assistant Bot commented Aug 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lbajsarowicz commented Jun 7, 2020 •

edited

Loading