Skip to content

MFTF: Admin Deletes Customer's Wishlist Item Test #28632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 19, 2020
Merged

MFTF: Admin Deletes Customer's Wishlist Item Test #28632

merged 4 commits into from
Jun 19, 2020

Conversation

DmitryTsymbal
Copy link
Contributor

@DmitryTsymbal DmitryTsymbal commented Jun 9, 2020 •
edited by m2-assistant bot
Loading

This PR contains a test for deleting items from customer wishlist as Admin user.

Steps to reproduce:

1 - Add a created product into wishlist as a customer
2 - Login as admin user
3 - Find created customer on grid
4 - Find added wishlist item
5 - Delete wishlist item
6 - Perform assertions

Resolved issues:

  1. resolves [Issue] MFTF: Admin Deletes Customer's Wishlist Item Test #28721: MFTF: Admin Deletes Customer's Wishlist Item Test

@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @DmitryTsymbal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Customer Component: Wishlist Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 9, 2020
@dmytro-ch dmytro-ch self-assigned this Jun 9, 2020
@dmytro-ch
Copy link
Contributor

@magento run all tests

lbajsarowicz
lbajsarowicz suggested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two elements that make this test flaky. Please take a look and adjust these 👍

app/code/Magento/Customer/Test/Mftf/Section/AdminCustomerWishlistSection.xml Outdated
<section name="AdminCustomerWishlistSection">
<element name="productName" type="input" selector="#wishlistGrid_filter_product_name"/>
<element name="searchButton" type="button" selector=".action-default.scalable.action-secondary"/>
<element name="deleteButton" type="text" selector=".even > td:nth-child(7) > a:nth-child(1)"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very flaky way to find the element.
If there is no other option, even selecting by label is more appropriate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored

app/code/Magento/Wishlist/Test/Mftf/Test/AdminDeleteCustomerWishListItemTest.xml
<createData entity="SimpleSubCategory" stepKey="createCategory"/>
<createData entity="SimpleProduct" stepKey="createProduct">
<requiredEntity createDataKey="createCategory"/>
</createData>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bear in mind that tests might be run in "on schedule" indexing mode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added cron cli

@ghost ghost assigned lbajsarowicz Jun 10, 2020
@lbajsarowicz
Copy link
Contributor

@magento run all tests

I'm going to review the PR in an hour or two

lbajsarowicz
lbajsarowicz approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Well done! Thank you for contribution.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7674 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 12, 2020
@engcom-Alfa engcom-Alfa self-assigned this Jun 15, 2020
@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jun 15, 2020
Closed
@engcom-Alfa engcom-Alfa added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 15, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Jun 15, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 16, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 16, 2020
@slavvka
Copy link
Member

slavvka commented Jun 18, 2020

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Jun 19, 2020
@slavvka
ENGCOM-7674: MFTF: Admin Deletes Customer's Wishlist Item Test #28632
0df29fe
@magento-engcom-team magento-engcom-team merged commit d9a4589 into magento:2.4-develop Jun 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 19, 2020

Hi @DmitryTsymbal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Customer Component: Wishlist Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] MFTF: Admin Deletes Customer's Wishlist Item Test
7 participants
@DmitryTsymbal @dmytro-ch @lbajsarowicz @magento-engcom-team @engcom-Alfa @engcom-Charlie @slavvka