Close prompt immediately after click ok instead of wait ajax request

[Nazar65]

Description (*)

The prompt need to be closed after press ok button instead of wait ajax request, because after unsuccessful response there is conflict with alert prompt

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Alert appears twice when the folder creation is not successful adobe-stock-integration#840

Manual testing scenarios (*)

1. On CMS edit page open media gallery
2. Load 5 images from Adobe Stock. One by one without page reload.
   Every next save of the image will drastically decrease performance. (Memory leak suspected)
3. Click "Create Folder"
4. Type in "Folder"
5. Click "OK"
6. When alert with a message "Please rename the folder Please rename the folder using only letters, numbers, underscores and dashes." appears, click "OK"
7. Click anywhere on the dark overlay

Expected result (*)

1. Alert appears only once

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[Nazar65]

@magento run all tests

[Nazar65]

Already covered by mftf test app/code/Magento/Cms/Test/Mftf/Test/AdminCheckCreateFolderEscapeAndEnterHandlesForWYSIWYGBlockTest.xml

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7690 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA Passed

Manual testing scenarios (*)

1. On CMS edit page open media gallery
2. Load 5 images from Adobe Stock. One by one without page reload.
   Every next save of the image will drastically decrease performance. (Memory leak suspected)
3. Click "Create Folder"
4. Type in "Folder"
5. Click "OK"
6. When alert with a message "Please rename the folder Please rename the folder using only letters, numbers, underscores and dashes." appears, click "OK"
7. Click anywhere on the dark overlay

Expected result (*)

1. Alert appears only once. After clicking OK the Attention message is closed immediately

[m2-assistant]

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.