Skip to content

MFTF: Enabling Email To Friend Functionality. Assert Options #29042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 24, 2020
Merged

MFTF: Enabling Email To Friend Functionality. Assert Options #29042

merged 6 commits into from
Aug 24, 2020

Conversation

DmitryTsymbal
Copy link
Contributor

@DmitryTsymbal DmitryTsymbal commented Jul 8, 2020 •
edited by m2-assistant bot
Loading

Description
This PR with a test that Enables Email To A Friend Functionality in Admin Panel

Steps To reproduce:

1 - Login to admin
2 - Enable Email To A Friend Functionality
3 - Navigate to Stores->Configuration->Catalog->Email To A Friend
4 - Assert additional options

Resolved issues:

  1. resolves [Issue] MFTF: Enabling Email To Friend Functionality. Assert Options #29145: MFTF: Enabling Email To Friend Functionality. Assert Options

@m2-assistant
Copy link

m2-assistant bot commented Jul 8, 2020

Hi @DmitryTsymbal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Backend Component: Config Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 8, 2020
@dmytro-ch dmytro-ch self-assigned this Jul 8, 2020
@dmytro-ch
Copy link
Contributor

@magento run all tests

@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage labels Jul 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7804 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jul 15, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 15, 2020
Closed
@engcom-Kilo engcom-Kilo self-assigned this Jul 15, 2020
@engcom-Kilo engcom-Kilo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 15, 2020
@ghost ghost added Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Priority: P3 May be fixed according to the position in the backlog. and removed Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jul 15, 2020
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@slavvka
Copy link
Member

slavvka commented Jul 17, 2020

@magento run Functional Tests CE

slavvka
slavvka requested changes Jul 17, 2020
View reviewed changes
Copy link
Member

@slavvka slavvka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DmitryTsymbal Please fix the MFTF tests. They are failing since a couple of days ago there were introduced static checks for MFTF tests:

Test AdminCatalogEmailToFriendSettingsTest is missing the required annotations: severity
Test AdminCreateCreditMemoWithZeroPriceCheckOrderStatusTest is missing the required annotations: stories, severity

@ghost ghost assigned slavvka Jul 17, 2020
@DmitryTsymbal
Copy link
Contributor Author

Hello @slavvka , I have added missed severity annotation into AdminCatalogEmailToFriendSettingsTest test.
Unfortunately I have not permissions to add the same into AdminCreateCreditMemoWithZeroPriceCheckOrderStatusTest
Thanks!

@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Kilo engcom-Kilo requested a review from slavvka July 23, 2020 07:49
@ghost ghost assigned sidolov Aug 21, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-7804 has been created to process this Pull Request

magento-engcom-team pushed a commit that referenced this pull request Aug 24, 2020
@sidolov
ENGCOM-7804: MFTF: Enabling Email To Friend Functionality. Assert Opt…
c6e48ab 
…ions #29042
@magento-engcom-team magento-engcom-team merged commit c31c55f into magento:2.4-develop Aug 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 24, 2020

Hi @DmitryTsymbal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@slavvka slavvka Awaiting requested review from slavvka

Assignees

@slavvka slavvka

@sidolov sidolov

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Kilo engcom-Kilo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Backend Component: Config Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] MFTF: Enabling Email To Friend Functionality. Assert Options
7 participants
@DmitryTsymbal @dmytro-ch @magento-engcom-team @engcom-Alfa @engcom-Kilo @slavvka @sidolov