Skip to content

[MFTF] Add new AdminSelectAndDeleteProductsActionGroup#29427

Merged
magento-engcom-team merged 4 commits into
magento:2.4-developfrom
Usik2203:add-remove-product-actiogroup
Aug 14, 2020
Merged

[MFTF] Add new AdminSelectAndDeleteProductsActionGroup#29427
magento-engcom-team merged 4 commits into
magento:2.4-developfrom
Usik2203:add-remove-product-actiogroup

Conversation

@Usik2203

@Usik2203 Usik2203 commented Aug 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds new AdminSelectAndDeleteProductsActionGroup
This action group will select all product and remove them

@m2-assistant

m2-assistant Bot commented Aug 6, 2020

Copy link
Copy Markdown

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Bundle Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 6, 2020
@Usik2203

Usik2203 commented Aug 6, 2020

Copy link
Copy Markdown
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@Usik2203

Usik2203 commented Aug 7, 2020

Copy link
Copy Markdown
Contributor Author

@rogyar Could you review this one please ?
Thanks

@rogyar rogyar self-assigned this Aug 7, 2020
rogyar
rogyar reviewed Aug 7, 2020
View reviewed changes
Comment thread app/code/Magento/Bundle/Test/Mftf/ActionGroup/AdminSelectAndDeleteProductsActionGroup.xml Outdated

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminSelectAndDeleteProductsActionGroup">

@rogyar rogyar Aug 7, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest a little bit different name. Something like AdminDeleteAllProductsFromGridActionGroup.
Also, what do you think about moving this action group to the Catalog module?

@Usik2203 Usik2203 Aug 11, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Usik2203

Usik2203 commented Aug 10, 2020

Copy link
Copy Markdown
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@Usik2203

Usik2203 commented Aug 10, 2020

Copy link
Copy Markdown
Contributor Author

@magento run Functional Tests B2B

@VladimirZaets VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 11, 2020
@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 12, 2020
@magento-engcom-team

magento-engcom-team commented Aug 12, 2020

Copy link
Copy Markdown
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8002 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Aug 13, 2020
@engcom-Alfa

engcom-Alfa commented Aug 13, 2020

Copy link
Copy Markdown
Contributor

QA not applicable

@engcom-Charlie engcom-Charlie self-assigned this Aug 13, 2020
@engcom-Charlie

engcom-Charlie commented Aug 13, 2020

Copy link
Copy Markdown
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Aug 13, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 14, 2020
@slavvka
ENGCOM-8002: [MFTF] Add new AdminSelectAndDeleteProductsActionGroup #…
6c7d16b 
…29427
@magento-engcom-team magento-engcom-team merged commit 6ed4538 into magento:2.4-develop Aug 14, 2020
@m2-assistant

m2-assistant Bot commented Aug 14, 2020

Copy link
Copy Markdown

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rogyar rogyar rogyar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels

Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Bundle Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Projects

Pull Requests Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Usik2203 @magento-engcom-team @engcom-Alfa @engcom-Charlie @rogyar @VladimirZaets