System configuration Validation for Customer/Admin Token life time

[ejaz-alam]

Description (*)

This field should be save empty, but incorrect validation was applied. Because of that, admin user couldn't save the empty value.

Manual testing scenarios (*)

Without the fix
Log in in the admin area
Go to Stores -> Configurations -> Services -> OAuth.
Save Customer Token Lifetime (hours) field without the value/empty.
Save Admin Token Lifetime (hours) field without the value/empty.
Did not saved the configuration without the integer value.

With the fix
Log in in the admin area
Go to Stores -> Configurations -> Services -> OAuth.
Save Customer Token Lifetime (hours) field without the value/empty.
Save Admin Token Lifetime (hours) field without the value/empty.
Configuration saved as mentioned in note comment.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• All new or changed code is covered with unit/integration tests (if applicable)

Resolved issues:

1. resolves Customer Token Life in system config #29487: Customer Token Life in system config

[m2-assistant]

Hi @aliejaz55. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[rogyar]

Hi @aliejaz55. Could you check the same issue for the admin token lifetime, please?

Also, according to the definition of done, all changes should be covered by autotests. Could I ask you to create a simple MFTF test for this case. The idea of this test is to go to the corresponding settings tab in the admin panel, leave the token lifetime value empty, save the settings and make sure that no error appears.

There's a documentation of the MFTF framework itself.

You can also check some examples from the recently merged PRs:

https://github.com/magento/magento2/pull/27371/files
https://github.com/magento/magento2/pull/27343/files
https://github.com/magento/magento2/pull/27029/files

And one more link for the best practices https://github.com/magento/magento-functional-tests-migration/wiki/Best-practices

Thank you!

[sidolov]

@magento create issue

[ejaz-alam]

@rogyar for admin token, it has the same issue. I am working on it. Will be resolved soon.

[VladimirZaets]

Hi @aliejaz55. Thank you for collaboration. Do you have some updates regarding test coverage? If you need some help on it, please tell us

[VladimirZaets]

@magento run all tests

[ejaz-alam]

Yes @VladimirZaets please guide me on this. I have searched about MFTF, but it looks tbat I have to setup all my system for this. Please tell any middle way, that I can use now and in future pull requests.

[ejaz-alam]

@rogyar please check this, removed required validation for admin token. Looking for some help in MFTF. That can also help me for future contribution.

[VladimirZaets]

@aliejaz55 here is you can find the documentation, how to setup mftf framework locally and how to run tests. If you will have more specific questions, feel free to ask

[engcom-Kilo]

@aliejaz55
Working with MFTF test

[engcom-Kilo]

@magento run all tests

[m2-assistant]

Hi @ejaz-alam, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[gabrieldagama]

@magento run all tests

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-8135 has been created to process this Pull Request

[engcom-Foxtrot]

@magento run all tests

[engcom-Foxtrot]

@magento run all tests

[ejaz-alam]

@magento run all tests

[m2-assistant]

Hi @ejaz-alam, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ejaz-alam]

@magento-engcom-team why the bug fix award removed?