#1760: Media Gallery Page opened successfully if "Enhanced Media Gallery" disabled #29632

jmonteros422 · 2020-08-18T12:10:13Z

Description (*)

This PR will fixes issue magento/adobe-stock-integration#1760

Related Pull Requests

Fixed Issues (if relevant)

Fixes Media Gallery Page opened successfully if "Enhanced Media Gallery" disabled adobe-stock-integration#1760: Media Gallery page and Category grid page opened successfully if "Enhanced Media Gallery" disabled

Preconditions (*)

Install Magento 2.4-develop with Adobe Stock Integration and IMS
Enhanced Media Gallery Disabled

Steps to reproduce (*)

Open https://yourdomain.com/admin/media_gallery/media/index link

Expected result (*)

404 page

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

… grid page opened successfully if "Enhanced Media Gallery" disabled - redirect to 404 if enhanced media gallery config is disabled.

m2-assistant · 2020-08-18T12:10:16Z

Hi @jmonteros422. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

jmonteros422 · 2020-08-18T12:10:44Z

@magento run all tests

sivaschenko

Thanks for the PR @jmonteros422 ! Can you please revert the changes for the Category grid page, only the Media Gallery page should not be acccesible.

Can you please also cover the changes by MFTF tests: 404 page should be returned trying to access media gallery by URL if it's disabled

… grid page opened successfully if "Enhanced Media Gallery" disabled - revert category grid no route redirect when media gallery is disabled, MFTF test coverage

jmonteros422 · 2020-08-19T09:06:14Z

@magento run all tests

sivaschenko

Thanks for the updates @jmonteros422 ! Please see my comments

sivaschenko · 2020-08-19T10:57:06Z

app/code/Magento/MediaGalleryUi/Test/Mftf/Test/AdminStandaloneMediaGalleryDisabledTest.xml

+            <testCaseId value="https://studio.cucumber.io/projects/131313/test-plan/folders/1337102/scenarios/5106786"/>
+            <description value="Standalone Media Gallery Page should return 404 if Media Gallery is disabled"/>
+            <severity value="CRITICAL"/>
+            <group value="media_gallery_ui"/>


Please intorduce a new media_gallery_ui_disabled suite that will not enable the new media gallery (that suite does not need any before/after actions actually)

sivaschenko · 2020-08-19T10:59:13Z

...diaGalleryUi/Test/Mftf/ActionGroup/AssertAdminStandaloneMediaGalleryPageIs404ActionGroup.xml

+  */
+-->
+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"


Please introduce this action group as app/code/Magento/Backend/Test/Mftf/ActionGroup/AssertAdminPageIs404ActionGroup.xml

… grid page opened successfully if "Enhanced Media Gallery" disabled - MFTF Apply PR suggestions

jmonteros422 · 2020-08-19T12:13:00Z

@magento run all tests

sivaschenko

Thanks for updates @jmonteros422 ! Please see my comments

sivaschenko · 2020-08-19T18:48:55Z

app/code/Magento/MediaGalleryUi/Test/Mftf/Test/AdminStandaloneMediaGalleryDisabledTest.xml

+        </annotations>
+        <before>
+            <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
+            <actionGroup ref="AdminMediaGalleryEnhancedEnableActionGroup" stepKey="disableEnhancedMediaGallery"/>


There is no need to disable media gallery as it is disabled by default

sivaschenko · 2020-08-19T18:49:16Z

app/code/Magento/MediaGalleryUi/Test/Mftf/Test/AdminStandaloneMediaGalleryDisabledTest.xml

+        <before>
+            <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
+            <actionGroup ref="AdminMediaGalleryEnhancedEnableActionGroup" stepKey="disableEnhancedMediaGallery"/>
+            <actionGroup ref="AdminOpenStandaloneMediaGalleryActionGroup" stepKey="openStandaloneMediaGallery"/>


opening media gallery is actually part of the test, not the precondition

sivaschenko · 2020-08-19T18:50:03Z

app/code/Magento/MediaGalleryUi/Test/Mftf/ActionGroup/AssertAdminPageIs404ActionGroup.xml

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AssertAdminPageIs404ActionGroup">


please move the action group to Backend module (see the exact path in the comment from previous review)

… grid page opened successfully if "Enhanced Media Gallery" disabled - MFTF Apply PR suggestions

jmonteros422 · 2020-08-20T16:58:03Z

@magento run all tests

sivaschenko · 2020-08-24T11:51:24Z

@magento run Functional Tests EE

magento-engcom-team · 2020-08-24T11:52:43Z

Hi @sivaschenko, thank you for the review.
ENGCOM-8064 has been created to process this Pull Request

chalov-anton · 2020-08-25T08:40:20Z

✔️ QA Passed

If thee New Media Gallery is disabled, the https://yourdomain.com/admin/media_gallery/media/index link leads to 404 Page not found

Manual testing scenario - https://studio.cucumber.io/projects/131313/test-plan/folders/1337102/scenarios/5106786

…ed Media Gallery" disabled #29632

m2-assistant · 2020-08-26T12:51:57Z

Hi @jmonteros422, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento/adobe-stock-integration#1760: Media Gallery page and Category…

afe499d

… grid page opened successfully if "Enhanced Media Gallery" disabled - redirect to 404 if enhanced media gallery config is disabled.

jmonteros422 added Component: MediaContentApi Project: ASI Component: MediaGalleryCatalogUi Component: MediaGalleryUi labels Aug 18, 2020

ghost added the Progress: pending review label Aug 18, 2020

magento-engcom-team added Release Line: 2.4 and removed Component: MediaContentApi labels Aug 18, 2020

jmonteros422 changed the title ~~magento/adobe-stock-integration#1760: Media Gallery page and Category grid page opened successfully if "Enhanced Media Gallery" disabled~~ #1760: Media Gallery page and Category grid page opened successfully if "Enhanced Media Gallery" disabled Aug 18, 2020

jmonteros422 requested a review from sivaschenko August 18, 2020 12:15

sivaschenko requested changes Aug 18, 2020

View reviewed changes

ghost assigned sivaschenko Aug 18, 2020

ghost added Progress: needs update and removed Progress: pending review labels Aug 18, 2020

jmonteros422 changed the title ~~#1760: Media Gallery page and Category grid page opened successfully if "Enhanced Media Gallery" disabled~~ #1760: Media Gallery Page opened successfully if "Enhanced Media Gallery" disabled Aug 18, 2020

magento/adobe-stock-integration#1760: Media Gallery page and Category…

0994c44

… grid page opened successfully if "Enhanced Media Gallery" disabled - revert category grid no route redirect when media gallery is disabled, MFTF test coverage

sivaschenko requested changes Aug 19, 2020

View reviewed changes

magento/adobe-stock-integration#1760: Media Gallery page and Category…

5a70b81

… grid page opened successfully if "Enhanced Media Gallery" disabled - MFTF Apply PR suggestions

sivaschenko requested changes Aug 19, 2020

View reviewed changes

magento/adobe-stock-integration#1760: Media Gallery page and Category…

2267021

… grid page opened successfully if "Enhanced Media Gallery" disabled - MFTF Apply PR suggestions

sivaschenko approved these changes Aug 24, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 24, 2020

magento-engcom-team added Component: Backend and removed Component: MediaGalleryCatalogUi labels Aug 24, 2020

chalov-anton self-assigned this Aug 25, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 25, 2020

chalov-anton added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 25, 2020

ghost added Progress: extended testing Progress: accept and removed Progress: testing in progress Progress: extended testing labels Aug 25, 2020

magento-engcom-team mentioned this pull request Aug 26, 2020

Question: Object Manager objects' get methods return 1 #1760

Closed

magento-engcom-team pushed a commit that referenced this pull request Aug 26, 2020

ENGCOM-8064: #1760: Media Gallery Page opened successfully if "Enhanc…

a440dd3

…ed Media Gallery" disabled #29632

magento-engcom-team merged commit 5937874 into magento:2.4-develop Aug 26, 2020

#1760: Media Gallery Page opened successfully if "Enhanced Media Gallery" disabled #29632

#1760: Media Gallery Page opened successfully if "Enhanced Media Gallery" disabled #29632

Uh oh!

Conversation

jmonteros422 commented Aug 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Aug 18, 2020

Uh oh!

jmonteros422 commented Aug 18, 2020

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

jmonteros422 commented Aug 19, 2020

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

sivaschenko Aug 19, 2020

Choose a reason for hiding this comment

Uh oh!

sivaschenko Aug 19, 2020

Choose a reason for hiding this comment

Uh oh!

jmonteros422 commented Aug 19, 2020

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

sivaschenko Aug 19, 2020

Choose a reason for hiding this comment

Uh oh!

sivaschenko Aug 19, 2020

Choose a reason for hiding this comment

Uh oh!

sivaschenko Aug 19, 2020

Choose a reason for hiding this comment

Uh oh!

jmonteros422 commented Aug 20, 2020

Uh oh!

sivaschenko commented Aug 24, 2020

Uh oh!

magento-engcom-team commented Aug 24, 2020

Uh oh!

chalov-anton commented Aug 25, 2020

Uh oh!

m2-assistant bot commented Aug 26, 2020

Uh oh!

Uh oh!

jmonteros422 commented Aug 18, 2020 •

edited

Loading