FIx text and images are displayed cropped if folder has long name && Filters isn`t applied on the "Category" #29633

Nazar65 · 2020-08-18T12:16:33Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Text and images are displayed cropped if folder has long name adobe-stock-integration#1758: Text and images are displayed cropped if folder has long name
Fixes Filters aren`t applied on the "Category" grid adobe-stock-integration#1763: Filters isn`t applied on the "Category"

Manual testing scenarios (*)

Go to Content -> Media Gallery
Create a folder with long name (for example: TTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEESSSSSSSSSSSSSSSSSSSSSSSTTTTTTTTTTTTTT)
Select it

"We couldn't find any records." text should be displayed without cropping it there is no any image. If there is any image, it should also be displayed without cropping.

Go to Content -> Media Gallery
Select uploaded image
Click on three dots -> View Details
Click on the link 'Categories..." in 'Used in' attribute
Delete the ?filters[asset_id]=[1] part of request from address line -> Press Enter key
Pay attention to the 'Active filters:'
Click on the "Clear all" link
Waite a few seconds and reload the page
Click on the "Filters" button
Enter any word in the "ID" field -> Apply Filters
Try to apply any filter

Filter should be applied

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-08-18T12:16:35Z

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Nazar65 · 2020-08-18T12:56:07Z

@magento run all tests

sivaschenko

Thanks for the PR @Nazar65 ! Can you please cover the fixed cases with the MFTF tests:

Creating a folder with more than 50 characters name
Applying a filter after following the link with url-filter-applier

sivaschenko · 2020-08-18T13:54:53Z

app/code/Magento/MediaGalleryUi/Model/Directories/GetFolderTree.php

@@ -84,8 +84,9 @@ private function getDirectories(): array
            }

            $pathArray = explode('/', $path);
+            $displayName = strlen(end($pathArray)) > 50 ? substr(end($pathArray),0,50)."..." : end($pathArray);


Please create a constant for 50

Nazar65 · 2020-08-19T11:37:26Z

@magento run all tests

…o HEAD

Nazar65 · 2020-08-19T13:31:53Z

@magento run all tests

Nazar65 · 2020-08-19T15:12:33Z

@magento run all tests

sidolov · 2020-08-19T17:16:22Z

app/code/Magento/MediaGalleryUi/Model/Directories/GetFolderTree.php

            $directories[] = [
-                'data' => count($pathArray) > 0 ? end($pathArray) : $path,
+                'data' => count($pathArray) > 0 ? $displayName : $path,


Not sure it's a right way to trim name on the backend, it would be better adapt frontend application to handle long names. Let's imagine that someone will decide to extend frontend implementation and provide new design (where long names will look good) and with such approach, we are limiting 3d party developers to use trimmed names only.

agree but there is some limitation in a frontend so i decided it can be more easier to fix this in a back-end part, but i will try one more time fix this behavior on a frontend.

@sidolov i'v changed implementation, instead of cutting folders as it was done in old media gallery and there is also this issue here ->

so when we have a long folders and the block is too small for it i had added ability to scroll, as we can have alot of folders created one in one and soon or later we also have same issue, so i think only adding ability to vertical scrolling when there is a lot folder will be correct

@Nazar65 sounds good to me! Look like it's the only solution in such case.

one by one folders revert cutting folders from backend

Nazar65 · 2020-08-20T11:11:30Z

@magento run all tests

Nazar65 · 2020-08-20T14:10:34Z

@magento run all tests

Nazar65 · 2020-08-21T12:11:50Z

@magento run all tests

engcom-Lima · 2020-08-21T12:36:55Z

✔️ QA Passed

"We couldn't find any records." text displayed without cropping if there is no image.

If there is an image, it displays without cropping.

Filter applied correctly

Manual testing scenario

Nazar65 · 2020-08-21T12:58:33Z

@sidolov there was some style issue, so i've added few new commits, need to review it again

Nazar65 · 2020-08-21T13:34:12Z

@magento run all tests

magento-engcom-team · 2020-08-21T14:08:41Z

Hi @sidolov, thank you for the review.
ENGCOM-8047 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

filters on product grid

engcom-Lima · 2020-08-21T15:51:03Z

✔️ QA Passed
See dependent comment

mftf test

Nazar65 · 2020-08-21T16:05:06Z

@magento run all tests

…long name && Filters isn`t applied on the "Category" #29633

m2-assistant · 2020-08-25T11:11:55Z

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

cut long folders name to avoid styles issue

9fd19aa

ghost added the Progress: pending review label Aug 18, 2020

magento-engcom-team added Component: MediaGalleryUi Release Line: 2.4 labels Aug 18, 2020

engcom-Golf added the Project: ASI label Aug 18, 2020

Correctly apply filters from url-applier do avoid dropping other filters

084f689

sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Aug 18, 2020

sivaschenko requested changes Aug 18, 2020

View reviewed changes

ghost assigned sivaschenko Aug 18, 2020

ghost added Progress: needs update and removed Progress: pending review labels Aug 18, 2020

Cover long folder names in media gallery with mftf test

363a100

Nazar65 added 4 commits August 19, 2020 15:32

Cover filters functionality

702d201

Merge branch '2.4-develop' of https://github.com/magento/magento2 int…

58b7d3b

…o HEAD

Cover url-filter-applier issue with mftf test

3757078

Correct jasmine tests && fix static tests

a246993

static tests fix

773c20c

sidolov requested changes Aug 19, 2020

View reviewed changes

ghost assigned sidolov Aug 19, 2020

Nazar65 added 2 commits August 20, 2020 14:08

Add ablility to scroll folders in case when we have a lot of included

523a8c9

one by one folders revert cutting folders from backend

Rever foders tests as it can't be veryfied by mftf tests

c7d50bb

fix static tests

18e7988

again css static tests

22e613c

ghost added Progress: extended testing and removed Progress: testing in progress labels Aug 21, 2020

css static test fix !!

338f510

engcom-Lima added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 21, 2020

sidolov approved these changes Aug 21, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: extended testing labels Aug 21, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 21, 2020

Remove product name assertion as other tests can leave some active

a572253

filters on product grid

ghost added Progress: extended testing and removed Progress: testing in progress labels Aug 21, 2020

Add ablility to ovveride same filter woth url applier, fix unstable

51188d9

mftf test

sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 24, 2020

ghost added Progress: accept and removed Progress: extended testing labels Aug 24, 2020

magento-engcom-team added the Component: Catalog label Aug 24, 2020

magento-engcom-team mentioned this pull request Aug 25, 2020

Missing Call to $procede() #1763

Closed

magento-engcom-team pushed a commit that referenced this pull request Aug 25, 2020

ENGCOM-8047: FIx text and images are displayed cropped if folder has …

45a8f71

…long name && Filters isn`t applied on the "Category" #29633

magento-engcom-team merged commit 0f70673 into magento:2.4-develop Aug 25, 2020

Nazar65 mentioned this pull request Aug 26, 2020

"Active filters" shows the "Asset:" filter which is empty if switch to the Default View again magento/adobe-stock-integration#1780

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIx text and images are displayed cropped if folder has long name && Filters isn`t applied on the "Category" #29633

FIx text and images are displayed cropped if folder has long name && Filters isn`t applied on the "Category" #29633

Nazar65 commented Aug 18, 2020

m2-assistant bot commented Aug 18, 2020

Nazar65 commented Aug 18, 2020

sivaschenko left a comment

sivaschenko Aug 18, 2020

Nazar65 Aug 18, 2020

Nazar65 commented Aug 19, 2020

Nazar65 commented Aug 19, 2020

Nazar65 commented Aug 19, 2020

sidolov Aug 19, 2020

Nazar65 Aug 20, 2020 •

edited

Loading

Nazar65 Aug 20, 2020

sidolov Aug 20, 2020

Nazar65 commented Aug 20, 2020

Nazar65 commented Aug 20, 2020

Nazar65 commented Aug 21, 2020

engcom-Lima commented Aug 21, 2020 •

edited

Loading

Nazar65 commented Aug 21, 2020

Nazar65 commented Aug 21, 2020

magento-engcom-team commented Aug 21, 2020

engcom-Lima commented Aug 21, 2020

Nazar65 commented Aug 21, 2020

m2-assistant bot commented Aug 25, 2020

FIx text and images are displayed cropped if folder has long name && Filters isn`t applied on the "Category" #29633

FIx text and images are displayed cropped if folder has long name && Filters isn`t applied on the "Category" #29633

Conversation

Nazar65 commented Aug 18, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Aug 18, 2020

Nazar65 commented Aug 18, 2020

sivaschenko left a comment

Choose a reason for hiding this comment

sivaschenko Aug 18, 2020

Choose a reason for hiding this comment

Nazar65 Aug 18, 2020

Choose a reason for hiding this comment

Nazar65 commented Aug 19, 2020

Nazar65 commented Aug 19, 2020

Nazar65 commented Aug 19, 2020

sidolov Aug 19, 2020

Choose a reason for hiding this comment

Nazar65 Aug 20, 2020 • edited Loading

Choose a reason for hiding this comment

Nazar65 Aug 20, 2020

Choose a reason for hiding this comment

sidolov Aug 20, 2020

Choose a reason for hiding this comment

Nazar65 commented Aug 20, 2020

Nazar65 commented Aug 20, 2020

Nazar65 commented Aug 21, 2020

engcom-Lima commented Aug 21, 2020 • edited Loading

Nazar65 commented Aug 21, 2020

Nazar65 commented Aug 21, 2020

magento-engcom-team commented Aug 21, 2020

engcom-Lima commented Aug 21, 2020

Nazar65 commented Aug 21, 2020

m2-assistant bot commented Aug 25, 2020

Nazar65 Aug 20, 2020 •

edited

Loading

engcom-Lima commented Aug 21, 2020 •

edited

Loading