Removed fileinfo extension dependency from CMS module

[konarshankar07]

Description (*)

This PR will remove the dependency of fileinfo extension from the CMS

Fixed Issues (if relevant)

1. Fixes [Magento 2.3.2] Upload fails in image uploader #24332
2. Fixes [Magento 2.2.5 - 2.3.x] Upload fails in image uploader #16531
3. Fixes [Magento 2.3.5 p2] Upload fails in image uploader #29852

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @konarshankar07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[konarshankar07]

@magento run all tests

[konarshankar07]

@magento run all tests

[VladimirZaets]

Hi @konarshankar07, thanks for collaboration. Please take a look at my review comments and please fix the tests

[konarshankar07]

@magento run all tests

[konarshankar07]

@magento run all tests

[engcom-Charlie]

Hi, @konarshankar07 can you please fix static tests?
Thank you.

[engcom-Charlie]

@magento run all tests

[sivaschenko]

Thanks for updates @konarshankar07 ! Can you please cover the getFilesCollection method with an integration test

[konarshankar07]

Hello @sivaschenko ,

The method is already covered with integration test

magento2/dev/tests/integration/testsuite/Magento/Cms/Model/Wysiwyg/Images/StorageTest.php

Line 84 in d1ff2ca

public function testGetFilesCollection(): void

[konarshankar07]

@magento run all tests

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8116 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Precondition:

fileinfo php extension is disabled

Manual testing scenario:

1. Go to Admin -> Content -> Pages;
2. Open "Home Page" to edit (for ex.);
3. Expand the Content tab;
4. Select the image uploader ("Insert Image" button or the one in the editor);
5. Select an image from your HD and upload it.

Before: ✖️ Error: Call to undefined function mime_content_type()

✖️ An error is shown: "File validation failed." No image is uploaded.

After: ✔️ An image was successfully uploaded and added to a page

Also, was tested with enabled fileinfo extension, on blocks, widgets and everything works as expected.

[m2-assistant]

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.