Skip to content

Allow specify font type when declare custom font #29726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Aug 24, 2020

Description (*)

Previously custom font can added via theme by less file but some case font use other type (ttf,otf...) magento will not include correctly font. Font will not render properly. This patch allow frontend developers can specific font type when include font in theme.

Use case 1: no define font type -> use default font like before magento will gen font use woff/woff2
Use case 2: use font format -> Developers will need define both format and type for render font

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Font format incorrect import in theme #29719

Manual testing scenarios (*)

  1. Tested with font added with /web/css/source/_typography.less inside luma/blank theme or custom theme
  2. Use custom font non-default from magento (ttf, eot)
  3. use format specific while import font
  4. Also use type font specific too
  5. Make sure output css render and page load without problem. Font render correctly

Questions or comments

Tested with import Roboto font used ttf format
Screenshot from 2020-10-05 21-33-35

Before Result: ✖️

Font not found in network chrome devtools
font_before_change

styles-m.css render with font
Screenshot from 2020-10-05 21-26-58

After Result: ✔️

import
font_after_import
render styles-m.css
font_render_after
web font request
font_after_change

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 24, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 24, 2020
@edenduong edenduong self-assigned this Aug 25, 2020
@edenduong edenduong added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 25, 2020
@edenduong
Copy link
Contributor

@magento run all tests

@edenduong edenduong removed their assignment Aug 25, 2020
@edenduong edenduong removed the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 25, 2020
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-8068 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@mrtuvn mrtuvn force-pushed the allow-declare-font-type branch from 3d8183c to 9e48f91 Compare October 2, 2020 06:44
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Oct 2, 2020

@engcom-Alfa @engcom-Bravo @engcom-Kilo can you check this

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Oct 2, 2020

@magento run all tests

@engcom-Alfa engcom-Alfa added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Oct 2, 2020
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Oct 2, 2020

@magento run Functional Tests EE

@engcom-Alfa
Copy link
Contributor

Dev experience is required for testing this PR. Please note that Manual testing has not been performed.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Oct 5, 2020

@engcom-Alfa i have updated info manual tests ! Anything missing info here
If you need any info relate for test please let me know

@engcom-Foxtrot engcom-Foxtrot self-assigned this Oct 5, 2020
@engcom-Foxtrot
Copy link
Contributor

QA passed.

@engcom-Foxtrot engcom-Foxtrot added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 6, 2020
@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 6, 2020
@magento-engcom-team magento-engcom-team merged commit 5380c81 into magento:2.4-develop Oct 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 7, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mrtuvn mrtuvn deleted the allow-declare-font-type branch October 13, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Font format incorrect import in theme
7 participants