-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Allow specify font type when declare custom font #29726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specify font type when declare custom font #29726
Conversation
Hi @mrtuvn. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
Hi @VladimirZaets, thank you for the review.
|
d1430f6
to
3d8183c
Compare
3d8183c
to
9e48f91
Compare
@engcom-Alfa @engcom-Bravo @engcom-Kilo can you check this |
@magento run all tests |
@magento run Functional Tests EE |
Dev experience is required for testing this PR. Please note that Manual testing has not been performed. |
@engcom-Alfa i have updated info manual tests ! Anything missing info here |
QA passed. |
Hi @mrtuvn, thank you for your contribution! |
Description (*)
Previously custom font can added via theme by less file but some case font use other type (ttf,otf...) magento will not include correctly font. Font will not render properly. This patch allow frontend developers can specific font type when include font in theme.
Use case 1: no define font type -> use default font like before magento will gen font use woff/woff2
Use case 2: use font format -> Developers will need define both format and type for render font
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Tested with import Roboto font used ttf format

Before Result: ✖️
Font not found in network chrome devtools

styles-m.css render with font

After Result: ✔️
import



render styles-m.css
web font request
Contribution checklist (*)