Skip to content

#1832: Rename renditions stores config fieldset and add comments #30044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2020
Merged

#1832: Rename renditions stores config fieldset and add comments #30044

merged 3 commits into from
Sep 18, 2020

Conversation

joweecaquicla
Copy link

@joweecaquicla joweecaquicla commented Sep 14, 2020 •
edited
Loading

Description (*)

This PR will introduce the modifications to renditions stores config fieldset.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Rename renditions stores config fieldset and add comments adobe-stock-integration#1832

Manual testing scenarios (*)

  1. Go to Stores -> Configuration -> Advanced -> System
  2. "Media Gallery Renditions" should now be "Media Gallery Image Size"
  3. Expand "Media Gallery Image Size"
  4. Comments should be displayed (see attached screenshot)

Screen Shot 2020-09-15 at 2 18 20 AM

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

magento/adobe-stock-integration#1832: Rename renditions stores config…
45a224f 
… fieldset and add comments - modified config fieldset and added comments
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2020

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@joweecaquicla
Copy link
Author

@magento run all tests

sivaschenko
sivaschenko requested changes Sep 14, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @joweecaquicla ! Please see my comment

app/code/Magento/MediaGalleryRenditions/etc/adminhtml/system.xml Outdated
<label>Media Gallery Renditions</label>
<label>Media Gallery Image Size</label>
<comment>Resize images to improve performance and decrease the file size. When you use an image from Media Gallery on the storefront, the smaller image is generated and placed instead of the original.
Changing these settings will update all generated images.</comment>
<field id="width" translate="label" type="text" sortOrder="10" showInDefault="1" showInWebsite="0" showInStore="0">
<label>Max Width</label>
Copy link
Member

@sivaschenko sivaschenko Sep 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the fields and add field comments according to the mockup

Suggested change
<label>Max Width</label>
<label>Maximum Width</label>

@sivaschenko sivaschenko added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 14, 2020
@ghost ghost assigned sivaschenko Sep 14, 2020
@sivaschenko sivaschenko added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Sep 14, 2020
@sivaschenko sivaschenko added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: pending review and removed Progress: needs update labels Sep 14, 2020
magento/adobe-stock-integration#1832: Rename renditions stores config…
dd347f5 
… fieldset and add comments - additional modifications
@joweecaquicla
Copy link
Author

@magento run all tests

@sivaschenko sivaschenko mentioned this pull request Sep 14, 2020
Closed
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8207 has been created to process this Pull Request

@engcom-Bravo engcom-Bravo self-assigned this Sep 15, 2020
@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Sep 15, 2020 •
edited
Loading

✔️ QA Passed

Before switching to the PR
1

After switching to the PR
2

Rendition configuration is covered in several manual testing scenarios. For example in - https://studio.cucumber.io/projects/131313/test-plan/folders/1507933/scenarios/5183135

@joweecaquicla
Copy link
Author

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Sep 18, 2020
@sidolov
ENGCOM-8207: #1832: Rename renditions stores config fieldset and add …
c952484 
…comments #30044
@magento-engcom-team magento-engcom-team merged commit 8d78e4f into magento:2.4-develop Sep 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 18, 2020

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sivaschenko sivaschenko mentioned this pull request Sep 23, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@engcom-Bravo engcom-Bravo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: MediaGalleryRenditions Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI Release Line: 2.4 Risk: low Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename renditions stores config fieldset and add comments
5 participants
@joweecaquicla @magento-engcom-team @engcom-Bravo @sivaschenko @sidolov