26133: Fixed - Coupon code text field not display in proper width in … #30405

solwininfotech · 2020-10-10T08:05:24Z

…Internet Explorer/EDGE browser

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Coupon code text field not display in proper width in Internet Explorer/EDGE browser #26133 Coupon code text field not display in proper width in Internet Explorer/EDGE browser

Manual testing scenarios (*)

Add a product to the cart
Go to Shipping Cart Page

Before Fix

After Fix

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…Internet Explorer/EDGE browser

m2-assistant · 2020-10-10T08:05:26Z

Hi @solwininfotech. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

solwininfotech · 2020-10-10T08:09:34Z

@magento give me test instance

magento-deployment-service · 2020-10-10T08:09:37Z

Hi @solwininfotech. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2020-10-10T08:11:44Z

Hi @solwininfotech, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

solwininfotech · 2020-10-10T08:26:04Z

@magento give me test instance

magento-deployment-service · 2020-10-10T08:26:07Z

Hi @solwininfotech. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2020-10-10T08:28:21Z

Hi @solwininfotech, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

solwininfotech · 2020-10-10T08:28:49Z

@magento run all tests

vijay-wagento · 2020-10-10T08:29:47Z

#dmcdindia2020

solwininfotech · 2020-10-10T10:15:16Z

@magento give me test instance

magento-deployment-service · 2020-10-10T10:15:18Z

Hi @solwininfotech. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2020-10-10T10:20:05Z

Hi @solwininfotech, here is your Magento Instance: https://b3d1bab4ae0e3544db667f7b8b1ff052.instances.magento-community.engineering
Admin access: https://b3d1bab4ae0e3544db667f7b8b1ff052.instances.magento-community.engineering/admin_e6c2
Login: eb9a32b8
Password: 60b7da6a48ab

solwininfotech · 2020-10-12T12:55:54Z

@magento run all tests

ptylek · 2020-10-13T06:38:49Z

app/design/frontend/Magento/luma/Magento_Checkout/web/css/source/module/_cart.less

@@ -727,6 +727,13 @@
                    position: static;
                }
            }
+            .content {
+                .fieldset {
+                    .actions-toolbar {


.actions-toolbar selector receives width: 1% from Magento_Paypal/web/css/source/module/_review.less. Can you check it more thoroughly?

Please also check if this works with just .block { .actions-toolbar selector path (remove .content and .fieldset selectors). Add empty lines before and after styles.

@ptylek, thank you for your revision changes that have been done and pushed.

solwininfotech · 2020-10-13T12:23:39Z

@magento run all tests

magento-engcom-team · 2020-10-14T06:50:45Z

Hi @ptylek, thank you for the review.
ENGCOM-8342 has been created to process this Pull Request

solwininfotech · 2020-10-15T06:38:35Z

@ptylek thank you for your guidance and approving changes.

engcom-Bravo · 2020-10-15T10:08:01Z

✔️ QA Passed

Manual testing scenario

Open Storefront from Internet Explorer browser
Add any product to Cart
Click on Cart, select View and Edit cart
Click on Apply Discount Code
Observe the Enter discount code field size

BEFORE applying changes provided in this PR

AFTER switching to the PR

Note

Also rechecked on Google Chrome browser, the field is not broken
Also rechecked on Luma Theme

…per width in … #30405

m2-assistant · 2020-10-16T13:36:49Z

Hi @solwininfotech, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

solwininfotech · 2020-10-17T08:36:54Z

Thank you @ptylek and all to help me to complete this ticket.

26133: Fixed - Coupon code text field not display in proper width in …

a535faa

…Internet Explorer/EDGE browser

ghost added the Progress: pending review label Oct 10, 2020

magento-engcom-team added Area: Design/Frontend Release Line: 2.4 labels Oct 10, 2020

magento-engcom-team added the Event: dmcdindia2020 label Oct 10, 2020

sivaschenko added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 10, 2020

fixed spacing issue

a37cf33

ptylek suggested changes Oct 13, 2020

View reviewed changes

ghost assigned ptylek Oct 13, 2020

ghost added Progress: needs update and removed Progress: pending review labels Oct 13, 2020

removed .content and .fieldset selectors

e8ad9ae

solwininfotech requested a review from ptylek October 14, 2020 05:19

ptylek approved these changes Oct 14, 2020

View reviewed changes

ptylek added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 14, 2020

ghost added Progress: ready for testing and removed Progress: needs update labels Oct 14, 2020

engcom-Bravo self-assigned this Oct 14, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Oct 15, 2020

engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 15, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Oct 15, 2020

engcom-Foxtrot self-assigned this Oct 15, 2020

ghost added Progress: accept and removed Progress: extended testing labels Oct 15, 2020

magento-engcom-team mentioned this pull request Oct 16, 2020

Coupon code text field not display in proper width in Internet Explorer/EDGE browser #26133

Closed

magento-engcom-team pushed a commit that referenced this pull request Oct 16, 2020

ENGCOM-8342: 26133: Fixed - Coupon code text field not display in pro…

03a3450

…per width in … #30405

magento-engcom-team merged commit 5921bc4 into magento:2.4-develop Oct 16, 2020

26133: Fixed - Coupon code text field not display in proper width in … #30405

26133: Fixed - Coupon code text field not display in proper width in … #30405

Uh oh!

Conversation

solwininfotech commented Oct 10, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Oct 10, 2020

Uh oh!

solwininfotech commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

solwininfotech commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

solwininfotech commented Oct 10, 2020

Uh oh!

vijay-wagento commented Oct 10, 2020

Uh oh!

solwininfotech commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

solwininfotech commented Oct 12, 2020

Uh oh!

ptylek Oct 13, 2020

Choose a reason for hiding this comment

Uh oh!

solwininfotech Oct 13, 2020

Choose a reason for hiding this comment

Uh oh!

solwininfotech commented Oct 13, 2020

Uh oh!

magento-engcom-team commented Oct 14, 2020

Uh oh!

solwininfotech commented Oct 15, 2020

Uh oh!

engcom-Bravo commented Oct 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Manual testing scenario

Note

Uh oh!

m2-assistant bot commented Oct 16, 2020

Uh oh!

solwininfotech commented Oct 17, 2020

Uh oh!

Uh oh!

engcom-Bravo commented Oct 15, 2020 •

edited

Loading