Github #31984: fix for array offset bug during some 404s (PHP 7.4)

[erfanimani]

Description (*)

Fixes "Trying to access array offset on value of type bool" when accessing certain non existing category paths for known products, on PHP 7.4.

Fixed Issues (if relevant)

1. Fixes Expecting 404, getting 500: "Trying to access array offset on value of type bool" #31984

Manual testing scenarios (*)

1. On PHP 7.4, as an admin, set "Generate "category/product" URL Rewrites" to "No"
2. Make a GET request to {nonexistentcategory}/{product_url} (where product_url is an existing saleable product)
3. Ensure status code is 404, not 500

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @erfanimani. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

Hi @erfanimani,
Could you cover your changes with any type of automated tests?

[erfanimani]

@ihor-sviziev I'm thinking it might be hard to isolate this particular issue as it's nested within a few private method calls, but I'll have a look tomorrow — thanks for the feedback

[erfanimani]

Hi @ihor-sviziev, I can't create unit tests as the SUT contains only private/protected methods. I can create a MFTF test that reproduces the error (although sometimes it won't, depending on PHP error reporting and PHP version), and simply returns a 404 not found if successful. I'm not sure how relevant a test like that would be for the future. What's your opinion?

See the original issue for steps to reproduce.

[ihor-sviziev]

I don’t think mftf test sis suitable here.
@engcom-Charlie do you feel we can cover this change with some unit / integration test? If so - could you share your thoughts how to do that?

[engcom-Charlie]

@ihor-sviziev I think can try via unit test by using reflection.
Smth like this https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Paypal/Test/Unit/Model/Payflow/Service/GatewayTest.php#L206

[ihor-sviziev]

@erfanimani @engcom-Charlie
TBH I have a feeling that this logic should be extracted to a separate model and tested separately. What do you think?

[ihor-sviziev]

Hi @erfanimani,
Could you cover your changes with the unit test, as suggested in #31985 (comment) ?

[erfanimani]

Thanks @ihor-sviziev, I'll try and update the PR.

[erfanimani]

@ihor-sviziev, please see the updated PR. I believe I've got 100% test coverage of the method that was changed. Feedback is appreciated.

Thanks.

[m2-assistant]

Hi @erfanimani, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ihor-sviziev]

Please add "Mock" suffix to all mocks

Suggested change

	private $urlRewriteFactory;
	private $urlRewriteFactoryMock;

[ihor-sviziev]

Let's define object types

Suggested change

	public function testFindProductRewriteByRequestPath(
	$data,
	$productFromDb,
	$categorySuffix,
	$categoryFromDb,
	$canBeShownInCategory,
	$expectedProductRewrite
	) {
	public function testFindProductRewriteByRequestPath(
	array $data,
	$productFromDb,
	string? $categorySuffix,
	$categoryFromDb,
	bool $canBeShownInCategory,
	array? $expectedProductRewrite
	): void {

[ihor-sviziev]

please define expected types for params

[erfanimani]

Thanks for the feedback @ihor-sviziev, I've updated the PR with your suggestions.

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run Integration Tests

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8884 has been created to process this Pull Request

[dmitriyprime]

✔️ QA pass

❌ Before:

✔️ After

[m2-assistant]

Hi @erfanimani, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.