Skip to content

Api framework graphql interfaces mark #32101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2021
Merged

Api framework graphql interfaces mark #32101

merged 1 commit into from
May 6, 2021

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Feb 10, 2021 •
edited
Loading

Description (*)

Mark GraphQL interfaces as API

lib/internal/Magento/Framework/GraphQl/Config/ConfigElementFactoryInterface.php
lib/internal/Magento/Framework/GraphQl/Config/ConfigElementInterface.php
lib/internal/Magento/Framework/GraphQl/Config/Element/FieldInterface.php
lib/internal/Magento/Framework/GraphQl/Config/Element/OutputFieldInterface.php
lib/internal/Magento/Framework/GraphQl/Config/Element/TypeInterface.php
lib/internal/Magento/Framework/GraphQl/Config/Element/UnionInterface.php
lib/internal/Magento/Framework/GraphQl/ConfigInterface.php
lib/internal/Magento/Framework/GraphQl/Query/ErrorHandlerInterface.php
lib/internal/Magento/Framework/GraphQl/Query/Resolver/Argument/FieldEntityAttributesInterface.php
lib/internal/Magento/Framework/GraphQl/Query/Resolver/Argument/SearchCriteria/ArgumentApplierInterface.php
lib/internal/Magento/Framework/GraphQl/Query/Resolver/BatchRequestItemInterface.php
lib/internal/Magento/Framework/GraphQl/Query/Resolver/BatchResolverInterface.php
lib/internal/Magento/Framework/GraphQl/Query/Resolver/BatchServiceContractResolverInterface.php
lib/internal/Magento/Framework/GraphQl/Query/Resolver/ContextInterface.php
lib/internal/Magento/Framework/GraphQl/Query/Resolver/IdentityInterface.php
lib/internal/Magento/Framework/GraphQl/Query/Resolver/ResolveRequestInterface.php
lib/internal/Magento/Framework/GraphQl/Query/Resolver/TypeResolverInterface.php
lib/internal/Magento/Framework/GraphQl/Query/ResolverInterface.php
lib/internal/Magento/Framework/GraphQl/Schema/SchemaGeneratorInterface.php
lib/internal/Magento/Framework/GraphQl/Schema/Type/Entity/MapperInterface.php
lib/internal/Magento/Framework/GraphQl/Schema/Type/Enum/DataMapperInterface.php
lib/internal/Magento/Framework/GraphQl/Schema/Type/InputTypeInterface.php
lib/internal/Magento/Framework/GraphQl/Schema/Type/Output/ElementMapper/FormatterInterface.php
lib/internal/Magento/Framework/GraphQl/Schema/Type/OutputTypeInterface.php
lib/internal/Magento/Framework/GraphQl/Schema/Type/WrappedTypeInterface.php
lib/internal/Magento/Framework/GraphQl/Schema/TypeInterface.php
lib/internal/Magento/Framework/GraphQlSchemaStitching/GraphQlReader/TypeMetaReaderInterface.php

Reference classes/interfaces also marked api
lib/internal/Magento/Magento/Framework/GraphQl/Schema/Type/ResolveInfo.php
lib/internal/Magento/Framework/GraphQl/Config/Element/Field.php
lib/internal/Magento/Framework/GraphQl/Query/Resolver/BatchResponse.php
lib/internal/Magento/Framework/GraphQl/Query/Resolver/Value.php
lib/internal/Magento/Framework/GraphQl/Schema.php

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Mark Framework GraphQL interfaces as API #32028

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

CC @sivaschenko

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 10, 2021

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Feb 10, 2021
@mrtuvn mrtuvn changed the base branch from 2.4-develop to 2.5-develop February 10, 2021 16:31
@mrtuvn mrtuvn force-pushed the api-framework-graphql-interfaces-mark branch from f98357c to 96b5f0a Compare February 11, 2021 08:41
@eduard13 eduard13 self-assigned this Feb 12, 2021
@eduard13 eduard13 added this to the 2.5 milestone Feb 12, 2021
@eduard13
Copy link
Contributor

@magento run all tests

@eduard13 eduard13 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 12, 2021
@eduard13 eduard13 closed this Feb 12, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 12, 2021

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@eduard13 eduard13 reopened this Feb 12, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 12, 2021

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.5-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 13, 2021

@magento run Database Compare, Functional Tests B2B, Static Tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 14, 2021

@magento run Static Tests, Functional Tests B2B, Database Compare

1 similar comment
@eduard13
Copy link
Contributor

@magento run Static Tests, Functional Tests B2B, Database Compare

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-8782 has been created to process this Pull Request

@eduard13
Copy link
Contributor

@magento run Database Compare

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 14, 2021

@gabrieldagama should this PR target to branch api-changes-develop

@gabrieldagama gabrieldagama changed the base branch from 2.4-develop to api-changes-develop April 15, 2021 10:30
@mrtuvn mrtuvn force-pushed the api-framework-graphql-interfaces-mark branch from 285d457 to bb8042d Compare April 15, 2021 11:09
@mrtuvn mrtuvn requested a review from gabrieldagama April 15, 2021 11:10
@mrtuvn
Mark Framework GraphQL interfaces as API
3ec2374 
update


update


update


update


update


Update TypeMetaReaderInterface.php

Revert change the return type of this function
@mrtuvn mrtuvn force-pushed the api-framework-graphql-interfaces-mark branch from bb8042d to 3ec2374 Compare April 22, 2021 12:02
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 22, 2021

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 22, 2021

cc @@gabrieldagama updated PR branch

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 26, 2021

@magento run all tests

1 similar comment
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 29, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 29, 2021

@magento run Unit Tests, Static Tests, Integration Tests, Functional Tests CE, Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@gabrieldagama
Copy link
Contributor

@mrtuvn, please ignore the failures, for now, they are related to the fact that api-changes-develop is not up to date with 2.4-develop, it will be fixed soon.

@gabrieldagama
Copy link
Contributor

@magento import code to https://github.com/magento-engcom/magento2ce

@magento-engcom-team
Copy link
Contributor

@gabrieldagama the branch with code successfully imported intomagento-engcom/magento2ce repository. Branch name: imported-magento-magento2-32101.

@magento-cicd2 magento-cicd2 merged commit 34e8722 into magento:api-changes-develop May 6, 2021
@m2-assistant
Copy link

m2-assistant bot commented May 6, 2021

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldagama gabrieldagama gabrieldagama approved these changes

@eduard13 eduard13 eduard13 approved these changes

Assignees

@gabrieldagama gabrieldagama

@eduard13 eduard13

@engcom-Foxtrot engcom-Foxtrot

@engcom-Oscar engcom-Oscar

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: GraphQL GraphQL Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Project: API Changes QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark Framework GraphQL interfaces as API
7 participants
@mrtuvn @eduard13 @magento-engcom-team @engcom-Oscar @gabrieldagama @magento-cicd2 @engcom-Foxtrot