Skip to content

Product images are being duplicated on import #32103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

markalston
Copy link

@markalston markalston commented Feb 11, 2021

Backport of PR #26713 to patch Magento 2.3.6

Description
Built on top of #21146 and #21855.

This PR adds image deletion so after import product will have images specified in the CSV. New images will be added, existing will not be duplicated and images not mentioned in the CSV will be removed. This PR has been created for 2.4-develop branch and when approved I'll create backport for 2.3 branch.

Fixed Issues
#14398: Images Not Replaced via CSV Import
#21885: Product images are being duplicated on import

Manual testing scenarios (*)
Import product CSV using Add/Update method multiple times
Check if image duplication happens or not

@m2-assistant
Copy link

m2-assistant bot commented Feb 11, 2021

Hi @markalston. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3 instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@markalston
Copy link
Author

@magento give me test instance

@magento-deployment-service
Copy link

Hi @markalston. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @markalston, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@markalston
Copy link
Author

@magento give me 2.3 instance

@magento-deployment-service
Copy link

Hi @markalston. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @markalston, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@duckchip
Copy link
Contributor

duckchip commented Mar 4, 2021

#31210 tagging this since it might be related

@gabrieldagama
Copy link
Contributor

Hi @markalston, currently we are not accepting contributions to the 2.3 release line, we recommend you to update to the latest Magento version to get this fix.

@m2-assistant
Copy link

m2-assistant bot commented May 18, 2021

Hi @markalston, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants