Improve cron error logging

app/code/Magento/Cron/Console/Command/CronCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
@@ -135,10 +136,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 $params[ProcessCronQueueObserver::STANDALONE_PROCESS_STARTED] = $bootstrapOptionValue;
             }
         }
+
         /** @var Cron $cronObserver */
         $cronObserver = $objectManager->create(Cron::class, ['parameters' => $params]);
         $cronObserver->launch();
-        $output->writeln('<info>' . 'Ran jobs by schedule.' . '</info>');
+
+        // phpcs:ignore Magento2.Functions.DiscouragedFunction.Discouraged
+        if (posix_isatty(STDOUT)) {
+            $output->writeln('<info>' . 'Ran jobs by schedule.' . '</info>');
+        }
 
         return Cli::RETURN_SUCCESS;
     }

app/code/Magento/Cron/Observer/ProcessCronQueueObserver.php

@@ -278,10 +278,12 @@ function ($a, $b) {
                 && $this->getCronGroupConfigurationValue($groupId, 'use_separate_process') == 1
             ) {
                 $this->_shell->execute(
-                    $phpPath . ' %s cron:run --group=' . $groupId . ' --' . Cli::INPUT_KEY_BOOTSTRAP . '='
+                    '%s %s cron:run --group=%s --' . Cli::INPUT_KEY_BOOTSTRAP . '='
                     . self::STANDALONE_PROCESS_STARTED . '=1',
                     [
-                        BP . '/bin/magento'
+                        $phpPath,
+                        BP . '/bin/magento',
+                        $groupId,
                     ]
                 );
                 continue;
@@ -854,7 +856,7 @@ private function processPendingJobs(string $groupId, array $jobsRoot, int $curre
         /** @var Schedule $schedule */
         foreach ($pendingJobs as $schedule) {
             if (isset($processedJobs[$schedule->getJobCode()])) {
-                // process only on job per run
+                // process only one of each job per run
                 continue;
             }
             $jobConfig = isset($jobsRoot[$schedule->getJobCode()]) ? $jobsRoot[$schedule->getJobCode()] : null;

app/code/Magento/Cron/Test/Unit/Console/Command/CronCommandTest.php

@@ -1,8 +1,10 @@
 <?php
+
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 declare(strict_types=1);
 
 namespace Magento\Cron\Test\Unit\Console\Command;
@@ -80,7 +82,7 @@ public function testExecute()
             new CronCommand($this->objectManagerFactory, $this->deploymentConfigMock)
         );
         $commandTester->execute([]);
-        $expectedMsg = 'Ran jobs by schedule.' . PHP_EOL;
+        $expectedMsg = '';
         $this->assertEquals($expectedMsg, $commandTester->getDisplay());
     }
 }

app/code/Magento/Cron/composer.json

@@ -5,6 +5,7 @@
         "sort-packages": true
     },
     "require": {
+        "ext-posix": "*",
         "php": "~8.1.0||~8.2.0",
         "magento/framework": "*",
         "magento/module-store": "*"

app/code/Magento/Cron/etc/di.xml

@@ -65,7 +65,7 @@
         <arguments>
             <argument name="tasks" xsi:type="array">
                 <item name="cronMagento" xsi:type="array">
-                    <item name="command" xsi:type="string">{magentoRoot}bin/magento cron:run | grep -v "Ran jobs by schedule" >> {magentoLog}magento.cron.log</item>
+                    <item name="command" xsi:type="string">{magentoRoot}bin/magento cron:run >> {magentoLog}magento.cron.log 2>&amp;1</item>
                     <item name="optional" xsi:type="boolean">false</item>
                 </item>
             </argument>

composer.json

@@ -29,6 +29,7 @@
         "ext-mbstring": "*",
         "ext-openssl": "*",
         "ext-pdo_mysql": "*",
+        "ext-posix": "*",
         "ext-simplexml": "*",
         "ext-soap": "*",
         "ext-sodium": "*",

lib/internal/Magento/Framework/Shell/CommandRendererBackground.php

@@ -5,20 +5,31 @@
  */
 namespace Magento\Framework\Shell;
 
+use Magento\Framework\App\Filesystem\DirectoryList;
+use Magento\Framework\Filesystem;
 use Magento\Framework\OsInfo;
 
 class CommandRendererBackground extends CommandRenderer
 {
+    /**
+     * @var Filesystem
+     */
+    protected $filesystem;
+
     /**
      * @var \Magento\Framework\OsInfo
      */
     protected $osInfo;
 
     /**
+     * @param Filesystem $filesystem
      * @param OsInfo $osInfo
      */
-    public function __construct(OsInfo $osInfo)
-    {
+    public function __construct(
+        Filesystem $filesystem,
+        OsInfo $osInfo
+    ) {
+        $this->filesystem = $filesystem;
         $this->osInfo = $osInfo;
     }
 
@@ -33,8 +44,14 @@ public function render($command, array $arguments = [])
     {
         $command = parent::render($command, $arguments);
 
+        $logFile = '/dev/null';
+        if ($groupId = $arguments[2] ?? null) {
+            $logDir = $this->filesystem->getDirectoryRead(DirectoryList::LOG)->getAbsolutePath();
+            $logFile = escapeshellarg($logDir . 'magento.cron.' . $groupId . '.log');
+        }
+
         return $this->osInfo->isWindows() ?
             'start /B "magento background task" ' . $command
-            : str_replace('2>&1', '> /dev/null &', $command);
+            : str_replace('2>&1', ">> $logFile 2>&1 &", $command);
     }
 }

lib/internal/Magento/Framework/Shell/Test/Unit/CommandRendererBackgroundTest.php

@@ -7,20 +7,34 @@
 
 namespace Magento\Framework\Shell\Test\Unit;
 
+use Magento\Framework\Filesystem;
+use Magento\Framework\Filesystem\Directory\ReadInterface;
 use Magento\Framework\OsInfo;
 use Magento\Framework\Shell\CommandRendererBackground;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class CommandRendererBackgroundTest extends TestCase
 {
+    /**
+     * Test path to Magento's var/log directory
+     *
+     * @var string
+     */
+    protected $logPath = '/path/to/magento/var/log/';
+
     /**
      * Test data for command
      *
      * @var string
      */
     protected $testCommand = 'php -r test.php';
 
+    /**
+     * @var Filesystem|MockObject
+     */
+    protected $filesystem;
+
     /**
      * @var OsInfo|MockObject
      */
@@ -30,23 +44,37 @@ protected function setUp(): void
     {
         $this->osInfo = $this->getMockBuilder(OsInfo::class)
             ->getMock();
+
+        $directoryMock = $this->getMockBuilder(ReadInterface::class)
+            ->getMock();
+        $directoryMock->expects($this->any())
+            ->method('getAbsolutePath')
+            ->willReturn($this->logPath);
+
+        $this->filesystem = $this->getMockBuilder(Filesystem::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->filesystem->expects($this->any())
+            ->method('getDirectoryRead')
+            ->willReturn($directoryMock);
     }
 
     /**
      * @dataProvider commandPerOsTypeDataProvider
      * @param bool $isWindows
      * @param string $expectedResults
+     * @param string[] $arguments
      */
-    public function testRender($isWindows, $expectedResults)
+    public function testRender($isWindows, $expectedResults, $arguments)
     {
         $this->osInfo->expects($this->once())
             ->method('isWindows')
             ->willReturn($isWindows);
 
-        $commandRenderer = new CommandRendererBackground($this->osInfo);
+        $commandRenderer = new CommandRendererBackground($this->filesystem, $this->osInfo);
         $this->assertEquals(
             $expectedResults,
-            $commandRenderer->render($this->testCommand)
+            $commandRenderer->render($this->testCommand, $arguments)
         );
     }
 
@@ -58,8 +86,21 @@ public function testRender($isWindows, $expectedResults)
     public function commandPerOsTypeDataProvider()
     {
         return [
-            'windows' => [true, 'start /B "magento background task" ' . $this->testCommand . ' 2>&1'],
-            'unix'    => [false, $this->testCommand . ' > /dev/null &'],
+            'windows' => [
+                true,
+                'start /B "magento background task" ' . $this->testCommand . ' 2>&1',
+                [],
+            ],
+            'unix-without-group-name' => [
+                false,
+                $this->testCommand . ' >> /dev/null 2>&1 &',
+                [],
+            ],
+            'unix-with-group-name' => [
+                false,
+                $this->testCommand . " >> '{$this->logPath}magento.cron.group-name.log' 2>&1 &",
+                ['php-executable', 'script-path', 'group-name'],
+            ],
         ];
     }
 }