Skip to content

[32013][PR to 2.4-develop] Marked AdvancedSearch, Analytics, Backend, Bundle, CardinalCommerce as API #32723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Apr 13, 2021

Description (*)

This PR fixes #32013

Related Pull Requests

#32167

Fixed Issues (if relevant)

  1. Fixes magento/magento2 Mark AdvancedSearch, Analytics, Backend, Bundle, CardinalCommerce as API #32013>

@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2021

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Apr 13, 2021
@Usik2203
Copy link
Contributor Author

@magento run all tests

@danielrussob
Copy link

@magento run Integration Tests

@danielrussob
Copy link

I confirm that this PR is just a code cleanup / marked as API some class. We are waiting for tests.

@danielrussob
Copy link

I confirm that all files mentioned in issue (#32013) are covered

@danielrussob
Copy link

Hi @Usik2203 , thank you for your contribution

Can you tell me why you have marked: app/code/Magento/Analytics/ReportXml/DB/SelectBuilder.php as API?

It's not linked in: #32013

@Usik2203 Usik2203 force-pushed the 32013-marked-as-api-242 branch from 2750bef to e9f801a Compare April 13, 2021 19:16
@Usik2203
Copy link
Contributor Author

@magento run all tests

@Usik2203
Copy link
Contributor Author

Hi @Usik2203 , thank you for your contribution

Can you tell me why you have marked: app/code/Magento/Analytics/ReportXml/DB/SelectBuilder.php as API?

It's not linked in: #32013

This file was marked as API for fixing static issue when PR was target to 2.5-develop branch . Removed this file from this PR now.

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests EE , WebAPI Tests

@danielrussob
Copy link

@magento run Static Tests

@Usik2203
Copy link
Contributor Author

@magento run all tests

@Usik2203
Copy link
Contributor Author

@magento run WebAPI Tests , Unit Tests , Static Tests , Sample Data Tests EE , Sample Data Tests B2B , Functional Tests EE , Functional Tests B2B

@danielrussob
Copy link

@magento run all tests

1 similar comment
@Usik2203
Copy link
Contributor Author

@magento run all tests

@Usik2203 Usik2203 changed the base branch from api-changes-develop to 2.4-develop April 22, 2021 12:42
@Usik2203
Copy link
Contributor Author

@magento run all tests

@danielrussob
Copy link

@magento run Functional Tests B2B, Functional Tests EE

@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-9069 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@gabrieldagama
Copy link
Contributor

@magento-engcom-team
Copy link
Contributor

@gabrieldagama the branch with code successfully imported intomagento-engcom/magento2ce repository. Branch name: imported-magento-magento2-32723.

@gabrieldagama
Copy link
Contributor

This PR has been merged to api-changes-develop.

@m2-assistant
Copy link

m2-assistant bot commented May 6, 2021

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: AdvancedSearch Component: Analytics Component: Backend Component: Bundle Component: CardinalCommerce Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark AdvancedSearch, Analytics, Backend, Bundle, CardinalCommerce as API
5 participants