Add aria-label to page jump #33067

bradleybrecher · 2021-05-25T03:20:02Z

Description (*)

Issue : 2.4.4 Link Purpose (In Context))

Summary: The same link text, ... is used for links going to different page jumps. Users might not know the difference between each ... if there is no explanation

Fix: Add an 'aria-label' which indicates the page the user is skipping to

Related Pull Requests

N/A

Fixed Issues (if relevant)

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Add aria-label to page jump #33075: Add aria-label to page jump

m2-assistant · 2021-05-25T03:20:04Z

Hi @bradleybrecher. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

bradleybrecher · 2021-05-25T03:23:27Z

I will not make a test for this addition, so someone feel free to add it

gabrieldagama · 2021-05-25T16:13:01Z

@magento create issue

blmage · 2021-05-26T08:47:51Z

app/code/Magento/Theme/view/frontend/templates/html/pager.phtml

-                    <a class="page next jump" title="" href="<?= $block->escapeUrl($block->getNextJumpUrl()) ?>">
+                    <a class="page next jump"
+                       title=""
+                       aria-label="Skip to page <?= $block->escapeHtml($block->getNextJumpPage()) ?>"


Can you translate this?

@blmage can you clarify further what you mean by "translate this"?

@bradleybrecher 'Skip to Page' should be translatable with __()

change pushed & ready for another review

Den4ik · 2021-05-29T20:33:06Z

@magento run all tests

magento-automated-testing · 2021-05-29T20:33:14Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-07-01T14:48:10Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Alfa · 2021-07-29T08:23:14Z

@magento run Unit Tests

magento-automated-testing · 2021-07-29T08:23:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Alfa · 2021-08-10T17:54:12Z

Hi @bradleybrecher , @Den4ik & @blmage
Thanks for the collaboration & contribution!

❌ QA not Passed

Anchor links with text ... are not containing any labels. So required to add aria-label attribute

Manual Scenario Steps

Install Magento 2.4-develop instance with sample data.
Make sure to have any category with more than 12 products at least to see the next pagination link.
Admin side- Change the settings to have 3 dots for products next page navigation in the front end.
View the products list page in the front end and validate the next page ... (3 dots) anchor link

✔️ Expected result After Fix

Expected to have a aria-label attribute in the DOM to the link.

❌ Actual result After Fix

There is no aria-label attribute in the DOM to the link. Below is the screenshot of it.

Den4ik · 2021-08-13T09:54:45Z

@magento run all tests

magento-automated-testing · 2021-08-13T09:54:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-08-13T09:55:02Z

@engcom-Alfa I don't know how you tests it, but QA Passed for me

Actual Result

magento-engcom-team · 2021-08-13T09:56:53Z

Hi @Den4ik, thank you for the review.
ENGCOM-9108 has been created to process this Pull Request

Den4ik · 2021-08-13T09:58:15Z

@engcom-Alfa Looks like I understood.
Looks like you set ... to Anchor Text for Previous and Anchor Text for Next

Please follow little bit different scenario:

Set Pagination Frame Skip to 1

engcom-Alfa · 2021-08-25T11:37:07Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-08-25T11:37:12Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Alfa · 2021-08-25T11:37:43Z

@magento run Functional Tests CE

magento-automated-testing · 2021-08-25T11:37:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Alfa · 2021-08-25T11:37:59Z

@magento run Functional Tests EE

magento-automated-testing · 2021-08-25T11:38:04Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Alfa · 2021-08-26T07:26:07Z

@engcom-Alfa Looks like I understood.
Looks like you set ... to Anchor Text for Previous and Anchor Text for Next

Please follow little bit different scenario:

Set Pagination Frame Skip to 1

Thank you so much for the input @Den4ik ! This helped to proceed further. Thanks a lot

engcom-Alfa · 2021-08-26T07:34:33Z

✔️ QA Passed

Preconditions:

Install a fresh Magento instance with sample data.

Manual testing scenario:

Login to admin and navigate to Content>Configuration>Pagination
Set the Pagination Frame to 2; Set the Pagination Frame Skip to 1; Save the changes (Admin>Content>Design>Configuration> Select Global Default website > Pagination)
Front end: Navigate to Women>Tops; Scroll down the product listed page and check the pagination content with inspected tag's attributes.

Before: ✖️ There was no aria-label attribute to the link text ...

After: ✔️ aria-label attribute has been set to the link text ...

There is no additional regression is required since it is a aria-label attribute update to a particular link.

m2-assistant · 2021-09-23T15:54:50Z

Hi @bradleybrecher, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Add aria-label to page jump

4400de6

magento-engcom-team added Area: Frontend Component: Theme Release Line: 2.4 labels May 25, 2021

m2-community-project bot added the Progress: pending review label May 25, 2021

m2-assistant bot mentioned this pull request May 25, 2021

[Issue] Add aria-label to page jump #33075

Closed

4 tasks

gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 25, 2021

blmage reviewed May 26, 2021

View reviewed changes

m2-community-project bot assigned blmage May 26, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels May 26, 2021

Den4ik added Issue: needs update Additional information is require, waiting for response Progress: needs update and removed Issue: needs update Additional information is require, waiting for response labels May 26, 2021

m2-community-project bot added Progress: review and removed Progress: review Progress: needs update labels May 26, 2021

Den4ik self-assigned this May 26, 2021

Den4ik self-requested a review May 26, 2021 20:15

Den4ik added Progress: needs update and removed Progress: review labels May 26, 2021

m2-community-project bot added Progress: review and removed Progress: needs update labels May 26, 2021

Add translation & escape verbiage

0430a80

blmage removed their assignment May 28, 2021

m2-community-project bot added Progress: needs update and removed Progress: testing in progress labels Aug 10, 2021

Update previous jump label

b84bd72

Den4ik approved these changes Aug 13, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Aug 13, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Aug 16, 2021

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Aug 26, 2021

magento-engcom-team pushed a commit that referenced this pull request Sep 23, 2021

ENGCOM-9108: Add aria-label to page jump #33067

5a8cae1

magento-engcom-team merged commit f2e2cc1 into magento:2.4-develop Sep 23, 2021

Add aria-label to page jump #33067

Add aria-label to page jump #33067

Uh oh!

Conversation

bradleybrecher commented May 25, 2021 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented May 25, 2021

Uh oh!

bradleybrecher commented May 25, 2021

Uh oh!

gabrieldagama commented May 25, 2021

Uh oh!

blmage May 26, 2021

Choose a reason for hiding this comment

Uh oh!

bradleybrecher May 26, 2021

Choose a reason for hiding this comment

Uh oh!

Den4ik May 27, 2021

Choose a reason for hiding this comment

Uh oh!

bradleybrecher May 28, 2021

Choose a reason for hiding this comment

Uh oh!

Den4ik commented May 29, 2021

Uh oh!

magento-automated-testing bot commented May 29, 2021

Uh oh!

magento-automated-testing bot commented Jul 1, 2021

Uh oh!

engcom-Alfa commented Jul 29, 2021

Uh oh!

magento-automated-testing bot commented Jul 29, 2021

Uh oh!

engcom-Alfa commented Aug 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Den4ik commented Aug 13, 2021

Uh oh!

magento-automated-testing bot commented Aug 13, 2021

Uh oh!

Den4ik commented Aug 13, 2021

Uh oh!

magento-engcom-team commented Aug 13, 2021

Uh oh!

Den4ik commented Aug 13, 2021

Uh oh!

engcom-Alfa commented Aug 25, 2021

Uh oh!

magento-automated-testing bot commented Aug 25, 2021

Uh oh!

engcom-Alfa commented Aug 25, 2021

Uh oh!

magento-automated-testing bot commented Aug 25, 2021

Uh oh!

engcom-Alfa commented Aug 25, 2021

Uh oh!

magento-automated-testing bot commented Aug 25, 2021

Uh oh!

engcom-Alfa commented Aug 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Alfa commented Aug 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m2-assistant bot commented Sep 23, 2021

Uh oh!

Uh oh!

bradleybrecher commented May 25, 2021 •

edited by m2-assistant bot

Loading

engcom-Alfa commented Aug 10, 2021 •

edited

Loading

engcom-Alfa commented Aug 26, 2021 •

edited

Loading

engcom-Alfa commented Aug 26, 2021 •

edited

Loading