Skip to content

Fixes for the issues found by Unit Tests for PHP 8.1 compatibility #34454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2021
Merged

Fixes for the issues found by Unit Tests for PHP 8.1 compatibility #34454

merged 1 commit into from
Nov 10, 2021

Conversation

karyna-t
Copy link
Contributor

@karyna-t karyna-t commented Oct 27, 2021 •
edited
Loading

Description (*)

This PR is fixing existing Unit Tests (and related files from Magento Core) to be compatible with PHP 8.1.

Related Pull Requests

Related Issues

  1. Fix Unit tests to be compatible with PHP8.1 #34441

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 27, 2021

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Oct 27, 2021
@karyna-t
Copy link
Contributor Author

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess andrewbess self-assigned this Oct 27, 2021
@karyna-t karyna-t force-pushed the php8.1-compatibility/fix-unit-tests-core branch from 021651e to acd89d2 Compare October 27, 2021 20:24
@karyna-t
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t karyna-t force-pushed the php8.1-compatibility/fix-unit-tests-core branch from acd89d2 to 4ff0290 Compare October 28, 2021 11:33
@andrewbess
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t karyna-t force-pushed the php8.1-compatibility/fix-unit-tests-core branch from 4ff0290 to dec2dc7 Compare October 28, 2021 13:06
@karyna-t
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t karyna-t force-pushed the php8.1-compatibility/fix-unit-tests-core branch from dec2dc7 to 05ab7d9 Compare October 28, 2021 15:36
@karyna-t
Copy link
Contributor Author

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

3 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t
Copy link
Contributor Author

karyna-t commented Nov 1, 2021

test Magento\Wishlist\Test\Unit\Model\WishlistTest is fixed in #34453

static test Magento\Test\Php\LiveCodeTest::testCodeStyle fails because of the problem in magento-coding-standards.
There is a PR that should fix the issue:
magento/magento-coding-standard#319

@karyna-t karyna-t force-pushed the php8.1-compatibility/fix-unit-tests-core branch from be24044 to 412fa9d Compare November 1, 2021 11:29
@karyna-t
Copy link
Contributor Author

karyna-t commented Nov 1, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

2 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t karyna-t force-pushed the php8.1-compatibility/fix-unit-tests-core branch from 412fa9d to f8f06fe Compare November 8, 2021 11:11
@karyna-t karyna-t changed the title Fixes for the issues in framework found by Unit Tests for PHP 8.1 compatibility Fixes for the issues found by Unit Tests for PHP 8.1 compatibility Nov 8, 2021
@karyna-t karyna-t force-pushed the php8.1-compatibility/fix-unit-tests-core branch from f8f06fe to 32d2ca6 Compare November 8, 2021 11:58
@karyna-t
Copy link
Contributor Author

karyna-t commented Nov 8, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t karyna-t force-pushed the php8.1-compatibility/fix-unit-tests-core branch from 32d2ca6 to 1f6b615 Compare November 8, 2021 16:34
@karyna-t
Copy link
Contributor Author

karyna-t commented Nov 8, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t karyna-t force-pushed the php8.1-compatibility/fix-unit-tests-core branch from 1f6b615 to fffc16b Compare November 9, 2021 08:50
@karyna-t
Copy link
Contributor Author

karyna-t commented Nov 9, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Nov 10, 2021

Functional tests failures not related to changes in this PR.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 9d56b86 into magento:platform-health Nov 10, 2021
@karyna-t karyna-t deleted the php8.1-compatibility/fix-unit-tests-core branch November 26, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmav xmav xmav approved these changes

@andrewbess andrewbess andrewbess approved these changes

Assignees

@xmav xmav

@andrewbess andrewbess

Labels
Award: category of expertise Award: special achievement Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: ready for testing Project: Platform Health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karyna-t @andrewbess @xmav @magento-engcom-team @magento-devops-reposync-svc