Skip to content

#34394 Primary DI configuration is not merged properly #34457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

#34394 Primary DI configuration is not merged properly #34457

wants to merge 3 commits into from

Conversation

kandy
Copy link
Contributor

@kandy kandy commented Oct 27, 2021 •
edited by ihor-sviziev
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes migrateDataFromAnotherTable() does not work for declarative schema #34394
  2. Fixes Bug in DI generation: array arguments got replaced instead of merging when modified from different area #34464

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 27, 2021

Hi @kandy. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@kandy
Copy link
Contributor Author

kandy commented Oct 27, 2021

@magento run Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kandy
Copy link
Contributor Author

kandy commented Oct 27, 2021

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kandy kandy mentioned this pull request Oct 27, 2021
Closed
5 tasks
@ihor-sviziev
Copy link
Contributor

I think it's better to run all tests and review all the results.
PS: original links were

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev
ihor-sviziev requested changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kandy,
Could you review the test failures and adjust your solution accordingly?

@ihor-sviziev ihor-sviziev added Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Oct 28, 2021
@Den4ik Den4ik self-requested a review October 28, 2021 14:13
@Den4ik Den4ik self-assigned this Oct 28, 2021
@Den4ik
Copy link
Contributor

Den4ik commented Oct 28, 2021

As I see most failed tests completely not related to PR changes.
Let's try rerun after update from 2.4-develop branch.

@Den4ik
Copy link
Contributor

Den4ik commented Oct 28, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Oct 28, 2021
@ihor-sviziev
Copy link
Contributor

@Den4ik as you see - they are related

@Den4ik
Copy link
Contributor

Den4ik commented Oct 28, 2021 •
edited
Loading

@ihor-sviziev yep, same Tests failed again, but, for example, failed static tests looks little bit strange

@DmitryFurs
Copy link
Contributor

DmitryFurs commented Nov 17, 2021 •
edited
Loading

Here is an additional code snippet that contains a duplicate of the arguments associated with the initial problem. In order to add a $csp variable to the dictionary, in the Magento_Csp module, we need to repeat the arguments from app/etc/di.xml.

app/etc/di.xml - https://github.com/magento/magento2/blob/2.4-develop/app/etc/di.xml#L1919-L1926
Magento_Csp - https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Csp/etc/di.xml#L77-L85

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 6, 2021
@kandy
Copy link
Contributor Author

kandy commented Jan 26, 2022

Looks like this solution can be applied

@kandy kandy closed this Jan 26, 2022
@DmitryFurs
Copy link
Contributor

@kandy will this be fixed in the upcoming 2.4.4 release? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev requested changes

@Den4ik Den4ik Awaiting requested review from Den4ik

Assignees

@Den4ik Den4ik

@ihor-sviziev ihor-sviziev

Labels
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Component: ObjectManager Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
5 participants
@kandy @ihor-sviziev @Den4ik @DmitryFurs @magento-engcom-team