#35275: Minicart thumbnail image showing wrong size in frontend which…

[olegpola]

… is half of image size in XML

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Minicart thumbnail image showing wrong size in frontend which is half of image size in XML file #35275

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @olegpola. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[olegpola]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[manavluhar]

@olegpola Can you please sign CLA?

[hostep]

This will fix #35275 BTW, but I'm not convinced that this issue is actually valid. Maybe @engcom-Delta: can we try to get a product owner involved here in order to make sure this isn't accidentally merged in case the issue is found to not be valid...

[TuVanDev]

Hi @olegpola this pull request is invalid and will be caused a new issue: the thumbnail image will have a double size.

In the changes in PR 24743 @dmdanilchenko changed the width (and height) in both HTML and XML files:
app/code/Magento/Catalog/view/frontend/web/template/product/image_with_borders.html
app/design/frontend/Magento/blank/etc/view.xml
app/design/frontend/Magento/luma/etc/view.xml
You can take a look at PR's changed files here: https://github.com/magento/magento2/pull/24743/files

You guys had this issue because you declared width and height for<image id="mini_cart_product_thumbnail" type="thumbnail"> in your custom theme. But with the new change in PR 24743, the width and height size should be double. So issue #35275 is invalid.

Conclusion: The correct solution is double the size of height and width for <image id="mini_cart_product_thumbnail" type="thumbnail"> in /etc/view.xml, not changing any from app/code/Magento/Catalog/view/frontend/web/template/product/image_with_borders.html.

[ihor-sviziev]

Hi @olegpola,
I do agree with @Viper9x, the image should be 2x sized, so the real size on the website should be 2x smaller.
I'm closing this PR as not valid.