Spelling correction for 'email' within NOTICE OF LICENSE #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilist accepted as correct, e-mail is a 1980s: abbreviation of electronic mail. As such should be correctly spelt as 'e-mail' and not email. This commit correct's the spelling within the NOTICE OF LICENSE header. Future commits can then be made to correct further misspellings with adequate testing.
|
Wouldn't a proper abbreviation be e'mail? It matters not, I believe, as in legal texts abbreviations are considered inappropriate. Perhaps this commit should be changed to use the full phrasing of "electronic mail". Better yet - to be clear - perhaps everything should be written in Latin. |
|
Thank you for your contribution! After reviewing your proposal with the content writer we decided to not merge your pull request. When preparing labels for interface elements in Magento, we are following the Associated Press Stylebook. According to this guide, the word "e-mail" should be spelled as "email" without dash. We are closing this pull request so far. |
magento-team
pushed a commit
that referenced
this pull request
Jul 3, 2015
[Vanilla] (MAGETWO-38867) Improved declaration of widgets with `mixins` node Merged with failed (red) L1/REST EE build and failed (red) FAT/CreateGroupedProductEntityTest build. Reffering to those fails are know isssue and also fails in current mainline.
magento-team
pushed a commit
that referenced
this pull request
Feb 24, 2016
[API] Staging: Cart Price Rule
mmansoor-magento
pushed a commit
that referenced
this pull request
Sep 14, 2016
Bugs MAGETWO-57656 Base url should be processed while sending email
This was referenced Jan 15, 2018
Closed
magento-engcom-team
added a commit
that referenced
this pull request
Feb 21, 2019
- Merge Pull Request magento/graphql-ce#385 from magento/graphql-ce:GraphQL-292 - Merged commits: 1. 11b3a4f
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst accepted as correct, e-mail is a 1980s: abbreviation of electronic mail.
As such should be correctly spelt as 'e-mail' and not 'email'.
This commit corrects the spelling within the NOTICE OF LICENSE header.
Future commits can then be made to correct further misspellings with adequate testing.
This replaces the line...
to...
Please feel free to check any major dictionary.
http://www.thefreedictionary.com/email