Support newline in javascript translates#3892
Merged
magento-team merged 2 commits intomagento:developfrom May 10, 2016
Merged
Conversation
…the one with the opening/closing brackets (mage_translation_widget)
…the one with the opening/closing brackets (mage_translation_static)
Contributor
|
Thank you for your contribution. Please accept the contributors license agreement so this PR can be further processed. This can be done by clicking the "Details" link next to the "license/cla" check below. |
Contributor
Author
|
I added the email address used in the commit in my Github account, the CLA is now marked correctly |
Contributor
|
Internal ticket: MAGETWO-52573 |
Contributor
|
@stevenvdp Thank you for contribution. Your Pull Request merged to develop branch. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 13, 2019
[EngCom] Public Pull Requests - GraphQL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to add translates in js-translation.json if you use a newline after the opening brackets of the translate helper function in your templates.
This pull requests adds support for the following cases: