Page heading null issue fixed

[magentoabu]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Magento_Theme title.phtml template invalid for PHP 8.2 #39092

Manual testing scenarios (*)

1. Create a new cms page without title
2. Template do not crash if there's no page title.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @magentoabu. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[magentoabu]

@magento run all tests

[magentoabu]

@magento run Static Tests, Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

[magentoabu]

@magento run all tests

[magentoabu]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @magentoabu,

Thanks for the contribution!

The changes seem good to us but please fix the failed automated tests. Also please cover the changes with some automated tests.

Thanks

[engcom-Hotel]

Hello @magentoabu,

Have you got a chance to look into the review comments on this PR?

Thanks

[magentoabu]

@engcom-Hotel I'm working on it

[Den4ik]

Hi @magentoabu
Did you have a chance to fix static tests?

[magentoabu]

@magento run all tests

[magentoabu]

@Den4ik static test fixed

[magentoabu]

@engcom-Hotel This issue is only occurs if the cms page is created without heading, so its not possible to create cms page without heading in admin, the only way is create cms block using script or patch, i don't think automation tests is needed for this PR

[engcom-Hotel]

Hello @magentoabu,

After going through the issue again and the fix, I guess you are correct. We can move further with this PR.

Thanks

[Den4ik]

@magentoabu Looks good for me

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magentoabu Thank you for collaboration & contribution!

✔️ QA Passed

Preconditions:
Install Fresh Magento 2.4-develop

Steps to reproduce:
Create a CMS page without title using script/patch

Before:
As per PR description, in Php 8.2 passing null to trim() throws Exception: Deprecated Functionality: trim(): Passing null to parameter #1 ($string) of type string

After:

Functional Tests EE are failing hence moving this PR to Extended Testing.

Thank you.

[engcom-Dash]

@magento run Functional Tests EE

[engcom-Dash]

As all the checks have been successfully completed and are in green state, moving this PR to Merge in Progress.

Thank You.

[phaniseela]

thank you Abbas!