Skip to content

Conversation

@senthilengg
Copy link
Contributor

@senthilengg senthilengg commented Jun 6, 2025

…nditions

Description

Now Subselect validate will return true if there is no sub condition under subselect

Fixed Issues

  1. Fixes Salesrule Subselect with Quantity condition Fail to apply #39965

Manual testing scenarios

  1. Create a Rule as per the Bug report
  2. Add a product to cart
  3. Go to view cart and check whether the discount applied

@m2-assistant
Copy link

m2-assistant bot commented Jun 6, 2025

Hi @senthilengg. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@senthilengg
Copy link
Contributor Author

@magento run all tests

@senthilengg
Copy link
Contributor Author

@magento run Unit Tests

@senthilengg
Copy link
Contributor Author

@magento run Functional Tests CE

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 10, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jun 10, 2025
rbouma added a commit to rbouma/magento2 that referenced this pull request Jun 13, 2025
@engcom-Bravo
Copy link
Contributor

Hi @senthilengg,

Thank you for your contribution! The Magento core engineering team is working on the issue which you have addressed in this PR. Team will cherry pick the commits from your PR and may do further implementation to cover few more scenarios as needed. We will reach out to you if we need more information. For now, you can pause work on this PR.

Thank you once again!

@engcom-Bravo
Copy link
Contributor

Hi @senthilengg,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-14884 by the internal team
Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-14884&type=commits

Based on the Jira ticket, the target version is 2.4.9-alpha3.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Salesrule Subselect with Quantity condition Fail to apply

3 participants