Skip to content

Add SKU or ID to NoSuchEntityException in ProductRepository #40096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

mimou78
Copy link

@mimou78 mimou78 commented Jul 23, 2025

Description (*)

This PR improves the exception messages in Magento\Catalog\Model\ProductRepository::get() and getById() methods when a product is not found. The current message lacks context, which makes debugging harder.

Now the error message includes the SKU or ID used in the lookup.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Extra Logging When Requesting A Product Via Repository Fails #40090

Manual testing scenarios (*)

  1. Call GET /V1/products/unknown-sku via REST or use $productRepository->get('unknown-sku')
    • Before: The product that was requested doesn't exist.
    • After: The product with SKU "unknown-sku" does not exist.
  2. Call $productRepository->getById(999999)
    • Before: The product that was requested doesn't exist.
    • After: The product with ID "999999" does not exist.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Jul 23, 2025

Hi @mimou78. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@mimou78
Copy link
Author

mimou78 commented Jul 23, 2025

@magento run all tests

@mimou78 mimou78 changed the title fix: Add SKU or ID to NoSuchEntityException in ProductRepository (fixes #40090) Add SKU or ID to NoSuchEntityException in ProductRepository Jul 23, 2025
@mimou78 mimou78 marked this pull request as draft July 23, 2025 16:45
@mimou78
Copy link
Author

mimou78 commented Jul 24, 2025

@magento run WebAPI Tests Static Tests

Copy link

Failed to run the builds. Please try to re-run them later.

@mimou78
Copy link
Author

mimou78 commented Jul 24, 2025

@magento run WebAPI Tests Static Tests

Copy link

Failed to run the builds. Please try to re-run them later.

@mimou78 mimou78 marked this pull request as ready for review July 24, 2025 10:57
@mimou78
Copy link
Author

mimou78 commented Jul 24, 2025

@magento run WebAPI Tests Static Tests

Copy link

Failed to run the builds. Please try to re-run them later.

@mimou78 mimou78 marked this pull request as draft July 26, 2025 09:23
@mimou78
Copy link
Author

mimou78 commented Jul 26, 2025

@magento run WebAPI Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra Logging When Requesting A Product Via Repository Fails
1 participant