Skip to content

Conversation

@dimitriBouteille
Copy link
Contributor

@dimitriBouteille dimitriBouteille commented Dec 30, 2025

Description (*)

This PR refactors the setGuestEmailOnCart GraphQL mutation by extracting business logic from the resolver into a dedicated model class, improving code organization and testability.

Changes

  • New Model Class: Created Magento\QuoteGraphQl\Model\Cart\SetGuestEmailOnCart to handle the business logic of setting guest email on cart
  • Refactored Resolver: Updated Magento\QuoteGraphQl\Model\Resolver\SetGuestEmailOnCart to delegate business logic to the new model class
  • Unit Tests: Added comprehensive unit test coverage for the new model class (SetGuestEmailOnCartTest)

Motivation

The objective of this modification is to be able to more easily add logic (such as a custom control) before saving the email.

Today, the only solution is to make a beforeExecute plugin on the SetShippingMethodsOnCart class without benefiting from the controls already in place.

Manual testing scenarios (*)

Execute the graphQL setGuestEmailOnCart mutation, it must not have an error.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Move SetGuestEmailOnCart logic in a separated class #40398: Move SetGuestEmailOnCart logic in a separated class

@m2-assistant
Copy link

m2-assistant bot commented Dec 30, 2025

Hi @dimitriBouteille. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@dimitriBouteille
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

@dimitriBouteille
Copy link
Contributor Author

@engcom-Hotel Can you find the PHPUnit failed error ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

[Issue] Move SetGuestEmailOnCart logic in a separated class

2 participants