Skip to content

fixing setup:di:compile area order in plugin generation so frontend a… #40408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jakwinkler wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from
Open

fixing setup:di:compile area order in plugin generation so frontend a… #40408

jakwinkler wants to merge 6 commits into from

Conversation

@jakwinkler
Copy link
Contributor

@jakwinkler jakwinkler commented Jan 7, 2026

This PR fixes this bug:
#40407

@jakwinkler
fixing setup:di:compile area order in plugin generation so frontend a…
5905ab4 
…rea cache picks up compiled files instead of regenerating on the first request
@m2-assistant
Copy link

m2-assistant bot commented Jan 7, 2026

Hi @jakwinkler. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ct-prd-pr-scan
Copy link

ct-prd-pr-scan bot commented Jan 7, 2026

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].

@jakwinkler
Copy link
Contributor Author

jakwinkler commented Jan 7, 2026

@magento run all tests

@jakwinkler
Copy link
Contributor Author

jakwinkler commented Jan 7, 2026

@magento run all tests

@jakwinkler
Copy link
Contributor Author

jakwinkler commented Jan 8, 2026

@magento run all tests

@jakwinkler
Copy link
Contributor Author

jakwinkler commented Jan 10, 2026

@magento run all tests
and do it fast ;-)

@rhoerr rhoerr mentioned this pull request Jan 11, 2026
Merged
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 13, 2026
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rhoerr rhoerr rhoerr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review

Projects

Pull Requests Dashboard
Status: Pending Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakwinkler @rhoerr @engcom-Hotel