Skip to content

magento/magento2#40302: TypeError in Creditmemo\Validation\QuantityVa… #40429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shmVan wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

magento/magento2#40302: TypeError in Creditmemo\Validation\QuantityVa… #40429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/Magento/Sales/Model/Order/Creditmemo/Validation/QuantityValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Copyright 2016 Adobe
* Copyright 2026 Adobe
* All Rights Reserved.
*/
declare(strict_types=1);
Expand Down Expand Up @@ -133,7 +133,7 @@ private function validateTotalQuantityRefundable(
}
$orderItem = $orderItemsById[$item->getOrderItemId()];

if (!$this->isValidDecimalRefundQty($orderItem->getIsQtyDecimal(), $item->getQty())) {
if (!$this->isValidDecimalRefundQty($orderItem->getIsQtyDecimal(), (float)$item->getQty())) {
return __(
'We found an invalid quantity to refund item "%1".',
$orderItem->getSku()
Expand Down
22 changes: 22 additions & 0 deletions app/code/Magento/Sales/Test/Unit/Model/Order/Creditmemo/Validation/QuantityValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,28 @@ public static function dataProviderForValidateQty()
'expected' => [],
'isQtyDecimalAllowed' => false,
'isAllowZeroGrandTotal' => true
],
[
'orderId' => 1,
'orderItemId' => 1,
'qtyToRequest' => '1.0',
'qtyToRefund' => 1,
'sku' => 'sku',
'total' => 15,
'expected' => [],
'isQtyDecimalAllowed' => false,
'isAllowZeroGrandTotal' => true
],
[
'orderId' => 1,
'orderItemId' => 1,
'qtyToRequest' => '2.5',
'qtyToRefund' => 3,
'sku' => 'sku',
'total' => 15,
'expected' => [],
'isQtyDecimalAllowed' => true,
'isAllowZeroGrandTotal' => true
]
];
}
Expand Down