Skip to content

#40405: Fix invalid qty type to prevent TypeError on product view #40433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sydor-dev wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from
Open

#40405: Fix invalid qty type to prevent TypeError on product view #40433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd24e80
#40405: Fix invalid qty type to prevent TypeError on product view
sydor-dev Jan 9, 2026
1c7fe2d
Merge branch '2.4-develop' into issue-40405
sydor-dev Jan 9, 2026
049081a
Merge branch '2.4-develop' into issue-40405
sydor-dev Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions app/code/Magento/Catalog/Block/Product/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,15 +279,13 @@ public function isStartCustomization()
*/
public function getProductDefaultQty($product = null)
{
if (!$product) {
$product = $this->getProduct();
}
$product = $product ?: $this->getProduct();

$qty = max((float) $this->getMinimalQty($product), 1);

$qty = $this->getMinimalQty($product);
$config = $product->getPreconfiguredValues();
$configQty = $config->getQty();
if ($configQty > $qty) {
$qty = $configQty;
$configQty = $product->getPreconfiguredValues()->getQty();
if (is_numeric($configQty)) {
$qty = max($qty, (float) $configQty);
}

return $qty;
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Wishlist/Plugin/Helper/Product/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public function beforePrepareAndRender(
$params = null
) {
$qty = $controller->getRequest()->getParam('qty');
if ($qty) {
if ($qty && is_numeric($qty)) {
if (null === $params || !$params instanceof DataObject) {
$params = new DataObject((array) $params);
}
Expand Down