Skip to content

Performance fix the analytics_collect_data cron job long run #40463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexRapatij wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
+4 −4
Open

Performance fix the analytics_collect_data cron job long run #40463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f61f0d
Fix the long executing analytics_collect_data cron job
AlexRapatij Jan 27, 2026
5bc3960
Update the class description
AlexRapatij Jan 27, 2026
41b0604
Update the method description block
AlexRapatij Jan 27, 2026
9414940
Change limit from 0 to 1 in ReportValidatorTest
AlexRapatij Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/code/Magento/Analytics/ReportXml/DB/ReportValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
use Magento\Framework\Api\SearchCriteriaInterface;

/**
* Validates report definitions by doing query to storage with limit 0
* Validates report definitions by doing query to storage with limit 1
*/
class ReportValidator
{
Expand Down Expand Up @@ -39,7 +39,7 @@ public function __construct(ConnectionFactory $connectionFactory, QueryFactory $
}

/**
* Tries to do query for provided report with limit 0 and return error information if it failed
* Tries to do query for provided report with limit 1 and return error information if it failed
*
* @param string $name
* @param SearchCriteriaInterface $criteria
Expand All @@ -50,7 +50,7 @@ public function validate($name, ?SearchCriteriaInterface $criteria = null)
{
$query = $this->queryFactory->create($name);
$connection = $this->connectionFactory->getConnection($query->getConnectionName());
$query->getSelect()->limit(0);
$query->getSelect()->limit(1);
try {
$connection->query($query->getSelect());
} catch (\Zend_Db_Statement_Exception $e) {
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Analytics/Test/Unit/ReportXml/DB/ReportValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public function testValidate($reportName, $result, $stubType, $stubValue = null)
->with($connectionName)
->willReturn($this->connectionMock);
$this->queryMock->expects($this->atLeastOnce())->method('getSelect')->willReturn($this->selectMock);
$this->selectMock->expects($this->once())->method('limit')->with(0);
$this->selectMock->expects($this->once())->method('limit')->with(1);

// Configure query mock based on stub type
if ($stubType === 'returnValue') {
Expand Down