fix GraphQL list types not nullable #40464
Open
+28
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Non-nullable list item types were not correctly reflected in the generated GraphQL schema for output object types.
For example, the following definition in
schema.graphqls:Results in the following type in the stitched schema:
[WishListUserInputError]!Instead of the expected:
[WishListUserInputError!]!This issue affects all output object types. Input argument handling already behaved correctly.
This pull request fixes the schema generation logic to correctly preserve non-nullable list item types.
This same bug applied to tens of other types throughout the Magento GraphQL schema.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
[Type!]!inschema.graphqlsare preserved as
[Type!]!in the stitched schema.[Type]!.Questions or comments
Contribution checklist (*)