Skip to content

Conversation

@bramstroker
Copy link

@bramstroker bramstroker commented Jan 27, 2026

Description (*)

Non-nullable list item types were not correctly reflected in the generated GraphQL schema for output object types.

For example, the following definition in schema.graphqls:

type AddProductsToWishlistOutput @doc(description: "Contains the customer's wish list and any errors encountered.") {
    wishlist: Wishlist! @doc(description: "Contains the wish list with all items that were successfully added.")
    user_errors: [WishListUserInputError!]! @doc(description: "An array of errors encountered while adding products to a wish list.")
}

Results in the following type in the stitched schema:

[WishListUserInputError]!

Instead of the expected:

[WishListUserInputError!]!

This issue affects all output object types. Input argument handling already behaved correctly.

This pull request fixes the schema generation logic to correctly preserve non-nullable list item types.

This same bug applied to tens of other types throughout the Magento GraphQL schema.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Retrieve the GraphQL introspection schema.
  2. Verify that list fields defined as [Type!]! in schema.graphqls
    are preserved as [Type!]! in the stitched schema.
  3. Without this fix, the same fields appear incorrectly as [Type]!.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 27, 2026

Hi @bramstroker. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ct-prd-pr-scan
Copy link

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].

1 similar comment
@ct-prd-pr-scan
Copy link

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].

@bramstroker
Copy link
Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant