Fix overwrite default value image/file with NULL #5085
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you set a default value for a config field type image/file and you save it. It won't set the default value in the database. Instead it will save NULL and so overwrite the default config. With this change the default value will be set as value.
|
I want to agree to the CLA licence but i can't. I have the same issue as described in this issue: #5070 |
|
@joost-florijn-kega The branch for this PR is deleted. Please re-create PR from the new branch |
AntonEvers
pushed a commit
to AntonEvers/magento2
that referenced
this pull request
Jul 16, 2017
If you set a default value for a config field type image/file and you save it. It won't set the default value in the database. Instead it will save NULL and so overwrite the default config. With this change the default value will be set as value. This is a replication of what used to be in of magento#5085
This was referenced Jul 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
developbranch.image.Expected result
core_config_datawith default value.Actual result
core_config_datawith value NULL.If you set a default value for a config field type image/file and you save it. It won't set the default value in the database. Instead it will save NULL and so overwrite the default config.
With this change the default value will be set as value.