Skip to content

Translation in backend/validation.js #5254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Translation in backend/validation.js #5254

wants to merge 1 commit into from

Conversation

sIiiS
Copy link
Contributor

@sIiiS sIiiS commented Jun 25, 2016

added $.mage.__

@vkublytskyi
Copy link

@sIiiS, thank you for contribution. Would you combine your PRs #5252, #5253 and #5254 into single one?

@quienti
Copy link
Contributor

quienti commented Jun 27, 2016 •
edited
Loading

#4705

@sIiiS
Copy link
Contributor Author

sIiiS commented Jun 28, 2016

@vkublytskyi : yes please combine them if possible

@dvynograd dvynograd mentioned this pull request Jul 21, 2016
Merged
@dvynograd
Copy link
Contributor

@vkublytskyi Please take a look into that PR #5725

@vkorotun vkorotun added Progress: accept bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bugfix linked and removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Aug 4, 2016
@vkorotun
Copy link
Contributor

vkorotun commented Aug 8, 2016

Internal ticket: MAGETWO-56548

@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@VladimirZaets
Copy link
Contributor

Hello, @sIiiS. Thank you for contribution,the fix that you suggest is already merged in scope PR #5725. Please get back to us if you have any questions regarding it. Thanks.

@hostep hostep mentioned this pull request Sep 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Frontend bugfix Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sIiiS @vkublytskyi @quienti @dvynograd @vkorotun @VladimirZaets @MomotenkoNatalia