Skip to content

Frontend Label fixed for indexed array #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Frontend Label fixed for indexed array #531

wants to merge 1 commit into from

Conversation

haruair
Copy link

@haruair haruair commented Mar 14, 2014

I made integration c# code with magento SOAP . I tried to insert new product attribute but the error "Frontend label is not defined" popped up.

The problem was SAOP array started with 0 index and catalogProductAttributeFrontendLabelEntity[] in .NET Entity array started with 1 index. So I added this code for fixing index. This code makes reindexing the frontendLabel array.

@tanya-soroka
Copy link

Hello @haruair, I asked team to review our fix of request. Will back to you as soon as get some news.

@verklov verklov assigned verklov and tanya-soroka and unassigned verklov Apr 1, 2014
@verklov
Copy link
Contributor

verklov commented Apr 25, 2014

@haruair, I just received the results of review for your pull request. Unfortunately we cannot accept it. Below is the response explaining the reason.

The proposed solution is unacceptable as 0 index corresponds to the admin store, 1 - to the default store front store and so on. We must not change indexing to not spoil the data.

There is no problem from the Magento side here, but from the C# code performing invalid request to our SOAP API. While in any modern language you can serialize data in such a way that array starts from 0 index, like our code expects. Example for C#.

We are closing this pull request.

@verklov verklov closed this Apr 25, 2014
vpelipenko added a commit that referenced this pull request Aug 20, 2015
[Firedrakes] Visitors logging logic elimination
magento-team pushed a commit that referenced this pull request Apr 8, 2016
[Mustangs] MAGETWO-49507: Re-work tests to remove unnecessary requests and re-run those tests.
mmansoor-magento pushed a commit that referenced this pull request Oct 25, 2016
[MPI] OnePageCheckoutWithDiscountTest fix and PayPal configuration changes
magento-engcom-team added a commit that referenced this pull request Apr 29, 2019
…ems validation messages #531

 - Merge Pull Request magento/graphql-ce#531 from magento/graphql-ce:530-update-cart-items-validation-messages
 - Merged commits:
   1. 1267436
   2. e627992
   3. 357caac
   4. a081ebb
   5. 496d36a
   6. 3469559
   7. afa6c57
magento-devops-reposync-svc pushed a commit that referenced this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants