Changed di.xml so that all classnames starting with slashes are removed. #6842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
Already has been done in the meantime. No changes left in the PR. Thanks again! |
magento-engcom-team
pushed a commit
that referenced
this pull request
May 10, 2021
[Lynx] jQuery upgrade related refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The di.xml files are no consistent. In most of the cases a reference to a class is written this way: Magento\Framework\ClassName. I found 180 cases where there was a slash at the start of the class name, like this: \Magento\Framework\ClassName. Removed all the slashes before the Magento namespace so that it's consistent troughout the project.