-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Stickyjs improvements #7139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-team
merged 18 commits into
magento:develop
from
vovayatsyuk:improvements-stickyjs
Jun 27, 2017
Merged
Stickyjs improvements #7139
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8bfa048
SpacingTop feature added
vovayatsyuk 996d213
Trailing spaces was removed
vovayatsyuk a7254cf
Added stickyClass (css class) feature.
vovayatsyuk 798469a
Added offsetTop feature
vovayatsyuk 9f926ef
Merge branch 'develop' into improvements-stickyjs
vovayatsyuk c6d309b
Merge branch 'develop' into improvements-stickyjs
vovayatsyuk 766292c
Fixed offsetTop comparing bug
vovayatsyuk 0e479a3
Added stuck variable for better 'if' statement readability
vovayatsyuk ae7f764
Duplicated option value detection logic moved to separate function
vovayatsyuk dde585c
Shorthand method definition syntax replaced with standard one
vovayatsyuk 5071e54
OptionToNumber method refactored:
vovayatsyuk e6795cb
Better code readability
vovayatsyuk 7ae6be0
Fixed JSHint notices
vovayatsyuk db648a6
ESLint and JSCS fixes
vovayatsyuk fc0ae57
offsetTop option renamed into stickAfter as it has nothing with eleme…
vovayatsyuk febbd88
DocBlocks added for the new options
vovayatsyuk d715b42
DocBlock added for the 'container' option
vovayatsyuk 62b822c
Typo error in DocBlock fixed
vovayatsyuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you check value on function type? In what case it can be function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be useful to set a function for
stickAfter
parameter that will calculate sticky element height when you wish to stick element after it goes out of the viewport and the element could change its height dynamically (shopping cart for example)You can use different spacing top value for different screen size/orientation also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but can you leave docblock with description. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.