Skip to content

Translation for validate messages #7593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Translation for validate messages #7593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fecb3c3
Update form.phtml
redelschaap Nov 28, 2016
4767800
Update jquery.validate.js
redelschaap Nov 28, 2016
8e881db
Merge pull request #1 from redelschaap/patch-3
redelschaap Nov 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Review/view/frontend/templates/form.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
id="<?php echo $block->escapeHtmlAttr($_rating->getRatingCode()) ?>_<?php echo $block->escapeHtmlAttr($_option->getValue()) ?>"
value="<?php echo $block->escapeHtmlAttr($_option->getId()) ?>"
class="radio"
data-validate="{required:true, messages:{required:'Please select one of each of the ratings above.'}}"
data-validate="{required:true, messages:{required:'<?php echo __('Please select one of each of the ratings above.'); ?>'}}"
aria-labelledby="<?php echo $block->escapeHtmlAttr($_rating->getRatingCode()) ?>_rating_label <?php echo $block->escapeHtmlAttr($_rating->getRatingCode()) ?>_<?php echo $block->escapeHtmlAttr($_option->getValue()) ?>_label" />
<label
class="rating-<?php echo $block->escapeHtmlAttr($iterator); ?>"
Expand Down
34 changes: 17 additions & 17 deletions lib/web/jquery/jquery.validate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,22 +288,22 @@
},

messages: {
required: "This field is required.",
remote: "Please fix this field.",
email: "Please enter a valid email address.",
url: "Please enter a valid URL.",
date: "Please enter a valid date.",
dateISO: "Please enter a valid date (ISO).",
number: "Please enter a valid number.",
digits: "Please enter only digits.",
creditcard: "Please enter a valid credit card number.",
equalTo: "Please enter the same value again.",
maxlength: $.validator.format("Please enter no more than {0} characters."),
minlength: $.validator.format("Please enter at least {0} characters."),
rangelength: $.validator.format("Please enter a value between {0} and {1} characters long."),
range: $.validator.format("Please enter a value between {0} and {1}."),
max: $.validator.format("Please enter a value less than or equal to {0}."),
min: $.validator.format("Please enter a value greater than or equal to {0}.")
required: $.mage.__('This field is required.'),
remote: $.mage.__('Please fix this field.'),
email: $.mage.__('Please enter a valid email address.'),
url: $.mage.__('Please enter a valid URL.'),
date: $.mage.__('Please enter a valid date.'),
dateISO: $.mage.__('Please enter a valid date (ISO).'),
number: $.mage.__('Please enter a valid number.'),
digits: $.mage.__('Please enter only digits.'),
creditcard: $.mage.__('Please enter a valid credit card number.'),
equalTo: $.mage.__('Please enter the same value again.'),
maxlength: $.validator.format($.mage.__('Please enter no more than {0} characters.')),
minlength: $.validator.format($.mage.__('Please enter at least {0} characters.')),
rangelength: $.validator.format($.mage.__('Please enter a value between {0} and {1} characters long.')),
range: $.validator.format($.mage.__('Please enter a value between {0} and {1}.')),
max: $.validator.format($.mage.__('Please enter a value less than or equal to {0}.')),
min: $.validator.format($.mage.__('Please enter a value greater than or equal to {0}.'))
},

autoCreateRanges: false,
Expand Down Expand Up @@ -1274,4 +1274,4 @@
});
}(jQuery));

}));
}));