-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Improve address save flow to allow to use custom validators #7882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve address save flow to allow to use custom validators #7882
Conversation
@vovayatsyuk Please check this PR #8519: it fixes the similar issue of certain attributes being required. If it solves the same issue of some fields being required. Also, can you provide more details on how do you make those fields optional? |
@vovayatsyuk please merge the PR with the latest develop branch |
|
@vovayatsyuk Hi, Pull Request now has 0 Files changed after your last commit. Can you please check what happened? You might overwritten your changes by the mainline. |
@vovayatsyuk yes, please |
@vrann I've noticed in a couple of processed pull requests already that some guys are not using Git properly. Here you can see that cde83ef commit is present in mainline as 801c121. So, somebody did inappropriate rebase which changed the hash of initial commit. With proper Git usage this PR would be marked as Merged without any additional actions. |
@orlangur it was me :( In my previous PR I've made a mistake and decided to create another one. But someone from magento team already applied my changes from the first PR internally. So this PR become empty as soon as my original commit from the first PR was pushed to dev branch and I merged it in here. p.s. I'll be careful next time.. |
Oh :) That's totally unexpected. Sorry guys for disturbing you, I overlooked the probability of force push by PR author. |
I'm facing an issue, that I cannot make some fields optional because of hardcoded
validation of address fields. Moreover, validation is made in private method, so I can't use plugin for it.
Hopefully, there is a public validation method analogue, available in address class, that can be extended with plugins.