Update customer-data.js #8107
Closed
Update customer-data.js #8107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The customer's name was not showing after logging in, because private ko data wasn't loaded when the `privateContent` data was empty. Therefor the if statement should be vice versa.
|
@redelschaap your change will brake private content reload in case if cookie is present and not empty (if full page cache enabled). |
|
@ihor-sviziev Your fix also seems to fix my issue. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Mar 14, 2023
AC-7850: [2.4.6-develop] Build Failures with PHP 8.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The customer's name was not showing after logging in (in the welcome message), because private ko data wasn't loaded when the
privateContentdata was empty. Therefor the if statement should be vice versa.