Throw exception if joinAttribute is used#83
Closed
amenk wants to merge 1 commit intomagento:masterfrom
Closed
Conversation
A exception is better than a silent fail: Silent fails can cause very business critical problems that go unnoticed.
Contributor
Author
|
Actually there are some usages of joinAttribute which do not have effect at all and could be removed. For example in Mage_Sales_Block_Order_Recent::_construct(). I think I will try to run the whole testsuite and remove references. I think then we could remove the function completely ? @mage2-team Shall I go for that? |
Contributor
|
It looks like this method is not used anywhere (doesn't override any method and is not overridden), so it can be deleted. |
Contributor
Author
|
okay, so please delete it. |
Contributor
|
@amenk Code changes will be available after one of the next code publications to the GitHub from the internal repository. Thank you. |
okorshenko
pushed a commit
that referenced
this pull request
Nov 12, 2015
[Merchant beta] [Nord] Bug fix
magento-team
pushed a commit
that referenced
this pull request
Mar 23, 2016
JS-372 [Full-screen mode] Left and right side of image visible while video player is loading
ghost
mentioned this pull request
magento-engcom-team
added a commit
that referenced
this pull request
Jun 9, 2018
…elds list #83 - Merge Pull Request magento/graphql-ce#83 from sergy-gzh/graphql-ce:bugfix/26-imit-list-of-filterable-fields - Merged commits: 1. 38180f2
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 27, 2018
Merge 2.3-develop to EPAM-PR-2
magento-engcom-team
pushed a commit
that referenced
this pull request
May 1, 2019
5 tasks
5 tasks
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A exception is better than a silent fail: Silent fails can cause very business critical problems that go unnoticed.