-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Make Sales' emails $transport changeable from an observer #9755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Sales' emails $transport changeable from an observer #9755
Conversation
3257ea1
to
a7ac3a2
Compare
a1eb8fb
to
a42284b
Compare
Hi @EObukhovsky! Thanks for your contribution, I'll check this and get back to you if we have questions! |
@miguelbalparda thanks for the quick response! |
@EObukhovsky this seems to be a feature instead of a bug but I still see a lot of value in the PR. It might take some extra time to process but I'll do my best have this merged. Thanks again! |
After reviewing this in detail, it seems the original commit you mentioned introduced a change in the code and now the event variable transport is an object instead of an array. That might be a problem for backward compatibility, source here. |
@miguelbalparda good. A one more note from me: |
…ver #9755 - fixed BC issues
In the commit
44791d5#diff-f625923e436a1fdf17c94533d06a45fb
$transport
variable type was changed fromarray
to\Magento\Framework\DataObject
. in theMagento/Sales/Model/Order/Email/Sender/OrderSender
classAs the result
OrderSender
's$transport
became changeable from an observer.But
OrderCommentSender
,InvoiceSender
and others had been missed.This PR fixes it.
Contribution checklist