Skip to content

Improved error logging when trying to save a product#9890

Merged
magento-team merged 2 commits into
magento:developfrom
woutersamaey:develop
Jun 9, 2017
Merged

Improved error logging when trying to save a product#9890
magento-team merged 2 commits into
magento:developfrom
woutersamaey:develop

Conversation

@woutersamaey

@woutersamaey woutersamaey commented Jun 9, 2017

Copy link
Copy Markdown
Contributor

Description

Improved error logging for 2 cases:

  • The original exception was not passed as $cause in the new exception, when
  • The original exception is not logged sometimes when trying to save a product
    Now we can easily know the underlying exception.

Fixed Issues (if relevant)

None. General improvement

Manual testing scenarios

None. General improvement

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2

magento-cicd2 commented Jun 9, 2017

Copy link
Copy Markdown
Contributor

CLA assistant check
All committers have signed the CLA.

@ishakhsuvarov ishakhsuvarov self-assigned this Jun 9, 2017
@ishakhsuvarov ishakhsuvarov added this to the June 2017 milestone Jun 9, 2017
@woutersamaey woutersamaey changed the title Improved error logging: original exception was not passed as $cause Improved error logging when trying to save a product Jun 9, 2017
@magento-team magento-team merged commit fdb0c7f into magento:develop Jun 9, 2017
magento-team pushed a commit that referenced this pull request Jun 9, 2017
magento-devops-reposync-svc pushed a commit that referenced this pull request Jul 1, 2025
…ersion8

Acqe functional deployment version8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants