Skip to content

2.1 develop #9966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1,030 commits into from
Closed

2.1 develop #9966

wants to merge 1,030 commits into from

Conversation

angelo983
Copy link
Member

Inserts specified item into container at a specified position.

Description

Wrong evaluating check of position param (Position at which item should be inserted.)
let hang Checkout Page

Fixed Issues (if relevant)

lib/web/mage/utils/arrays.js
Line 105
from
if (typeof position === 'undefined') {
to
if (typeof position === 'undefined' || position == null) {

Manual testing scenarios

May happens while buying simple products of configurable products

OlgaVasyltsun and others added 30 commits March 2, 2017 10:56
…lation/rendering on Category page - for 2.1.6
…e cause locks on order page/api - for 2.1.6
…e cause locks on order page/api - for 2.1.6
…lation/rendering on Category page - for 2.1.6
…lation/rendering on Category page - for 2.1.6
…lation/rendering on Category page - for 2.1.6
…off swatches for category page - for 2.1.6
…off swatches for category page - for 2.1.6
…check FS operations (file_exists, is_file) - for 2.1.6
…off swatches for category page - for 2.1.6
…check FS operations (file_exists, is_file) - for 2.1.6
…check FS operations (file_exists, is_file) - for 2.1.6
…off swatches for category page - for 2.1.6
…off swatches for category page - for 2.1.6
…off swatches for category page - for 2.1.6
…off swatches for category page - for 2.1.6
…check FS operations (file_exists, is_file) - for 2.1.6
…off swatches for category page - for 2.1.6
…check FS operations (file_exists, is_file) - for 2.1.6
…off swatches for category page - for 2.1.6
…check FS operations (file_exists, is_file) - for 2.1.6
kassner and others added 23 commits May 29, 2017 07:55
…ned oldPrice #9776

 - Merge Pull Request #9776 from dreamworkers/magento2:fix/7959-oldprice-swatchrenderer
… the layered navigation options are sometimes being cached using the wrong store id. #9704

 - Merge Pull Request #9704 from hostep/magento2:issue-9679
 - Merge Pull Request #9601 from kassner/magento2:patch-6
… the layered navigation options are sometimes being cached using the wrong store id. #9704
[EngCom] Public Pull Requests - 2.1
 - MAGETWO-69541: #7959 - Fix for JS error on Swatch Renderer for undefined oldPrice #9776
… change currency

Fixed issues:

- MAGETWO-59089 [Github]Magento 2.1.1 Problem with change currency #6746
(cherry picked from commit a9510d3)
….1 Problem with change currency #9841

 - Merge Pull Request #9841 from hostep/magento2:backport-magetwo-59089
… the layered navigation options are sometimes being cached using the wrong store id. #9704
… the layered navigation options are sometimes being cached using the wrong store id. #970
[EngCom] Public Pull Requests - 2.1
 - MAGETWO-69665: Backport of MAGETWO-59089 for Magento 2.1: Magento 2.1.1 Problem with change currency #9841
 - MAGETWO-69543: Fixes regression bug introduced in Magento 2.1.6 where the layered navigation options are sometimes being cached using the wrong store id. #9704
 - MAGETWO-69151: Do not hardcode product link types [2.1 backport] #9601
 - MAGETWO-69691: Travis build failures because the job exceeded the maximum time limit for jobs - 2.1-develop
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 16, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 4 committers have signed the CLA.

❌ OlgaVasyltsun
❌ lestare
❌ RomaKis
❌ zakdma


lestare seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@ishakhsuvarov ishakhsuvarov self-assigned this Jun 16, 2017
@ishakhsuvarov
Copy link
Contributor

@angelo983 Looks like you have selected wrong branches by mistake (from develop into 2.1-develop). Please update and reopen if you wish to continue.
Thanks!

@angelo983
Copy link
Member Author

I found the bug in the 2.1-develop. Am I missing something I have to know about committing here instead of develop branch?

@ishakhsuvarov
Copy link
Contributor

@angelo983 Maybe you have mixed up the repositories or branches for the Pull Request, as currently, this PR is set up to merge 2.1-develop branch of magento/magento2 repository to the develop branch of the same magento/magento2 repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.