Skip to content

dbManager.Update does not respect [MagicNotMapped] attribute #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bitzblitz opened this issue Feb 9, 2025 · 3 comments
Closed

dbManager.Update does not respect [MagicNotMapped] attribute #24

bitzblitz opened this issue Feb 9, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@bitzblitz
Copy link
Contributor

After I call Update on an existing element in the database it updates with ALL fields, which messes up my data. When the record was originally saved my [MagicNotMapped] fields were not included in the records.

@magiccodingman magiccodingman added the bug Something isn't working label Feb 10, 2025
@yueyinqiu
Copy link
Collaborator

yueyinqiu commented Feb 13, 2025

It seems like in Update we forgot MagicNotMapped at all. Maybe also for encryption? I will check that as soon as possible. The relevant code is a bit messy. Maybe a great refactor is needed.

This was referenced Feb 14, 2025
@magiccodingman
Copy link
Owner

This bug is being resolved in this PR:
#38

will merge in changes and close it out after @yueyinqiu has time to check my back.

@magiccodingman
Copy link
Owner

#43
This not only further resolves this, but has massive performance improvements within the completely overhauled serialization system. Closing this and will put out a release when the finalized version is posted to NuGet. Just making sure all kinks are worked out prior to the next release as the refactor was so massive that it needs significant testing.

Closing this ticket. Please be advised to watch release status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants